Skip to content

tools: use Set instead of { [key]: true } object - #41695

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:tools-doc-alljson-seen-should-be-set
Jan 28, 2022
Merged

tools: use Set instead of { [key]: true } object#41695
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:tools-doc-alljson-seen-should-be-set

Conversation

@tniessen

@tniessentniessen commented Jan 25, 2022

Copy link
Copy Markdown
Member

I forgot about alljson.mjs in #41675...

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2022
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 25, 2022
@github-actions

github-actionsBot commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessentniessen changed the title tools: use Set instead of { [key]: true } objecttools: use Set instead of { [key]: true } objectJan 26, 2022
@tniessentniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 28, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 334fb38 into nodejs:masterJan 28, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2022

Copy link
Copy Markdown
Collaborator

Landed in 334fb38

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen@ruyadorno
tools: use Set instead of { [key]: true } object
3190e36
Refs: #41675
PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen@danielleadams
tools: use Set instead of { [key]: true } object
799f850
Refs: #41675
PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen@danielleadams
tools: use Set instead of { [key]: true } object
3918467
Refs: #41675
PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen@danielleadams
tools: use Set instead of { [key]: true } object
9d23a27
Refs: #41675
PR-URL: #41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@MesteeryMesteeryMesteery approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@lpinca@cjihrig@Mesteery@VoltrexKeyva