Uh oh!
There was an error while loading. Please reload this page.
test: make fs watch test more stable - #41715
Merged
nodejs-github-bot merged 1 commit intoJan 29, 2022
Merged
Conversation
benjamingrforce-pushed
the
test-fs-watch-non-recursive-stabilize
branch
from
January 27, 2022 10:41
e6f5abb to
ec2ac66Compare
This comment has been minimized.
This comment has been minimized.
Trott
reviewed
Jan 27, 2022
Uh oh!
There was an error while loading. Please reload this page.
Trott
reviewed
Jan 27, 2022
Uh oh!
There was an error while loading. Please reload this page.
Trott
commented
Jan 27, 2022
Member
@nodejs/testing |
benjamingrforce-pushed
the
test-fs-watch-non-recursive-stabilize
branch
from
January 27, 2022 11:09
ec2ac66 to
92af8b3Comparenodejs-github-bot
commented
Jan 27, 2022
Collaborator
cjihrig
approved these changes
Jan 27, 2022
richardlau
approved these changes
Jan 27, 2022
nodejs-github-bot
commented
Jan 27, 2022
Collaborator
lpinca
approved these changes
Jan 27, 2022
22 tasks
jasnell
approved these changes
Jan 28, 2022
22 tasks
nodejs-github-bot
commented
Jan 29, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41715 ✔ Done loading data for nodejs/node/pull/41715 ----------------------------------- PR info ------------------------------------ Title test: make fs watch test more stable (#41715) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:test-fs-watch-non-recursive-stabilize -> nodejs:master Labels test, flaky-test, needs-ci Commits 1 - test: make fs watch test more stable Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/41715 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41715 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 27 Jan 2022 10:41:26 GMT ✔ Approvals: 5 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41715#pullrequestreview-864717732 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41715#pullrequestreview-865074990 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41715#pullrequestreview-865081510 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41715#pullrequestreview-865332525 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41715#pullrequestreview-866774036 ✖ This PR needs to wait 9 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-01-27T15:58:30Z: https://ci.nodejs.org/job/node-test-pull-request/42195/ - Querying data for job/node-test-pull-request/42195/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1764418351 |
nodejs-github-bot
commented
Jan 29, 2022
Collaborator
Landed in 05e9cb6 |
This was referenced Jan 30, 2022
31 tasks
ruyadorno pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41715 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41715 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41715 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41715 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test currently uses a timeout to deal with a watch event for the directory being created.
This is flaky e.g. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=2,nodes=win10-COMPILED_BY-vs2019/lastCompletedBuild/testReport/(root)/test/pummel_test_fs_watch_non_recursive_/
Instead this changes the
common.mustNotCallto allow calls withtestdirnameso we do not depend on timing as much.