Skip to content

src: fix typo in js_native_api_v8.cc - #41764

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
caioagiani:patch-1
Feb 2, 2022
Merged

src: fix typo in js_native_api_v8.cc#41764
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
caioagiani:patch-1

Conversation

@caioagiani

@caioagianicaioagiani commented Jan 30, 2022

Copy link
Copy Markdown
Contributor
  • src/js_native_api_v8.cc NAPI_AUTO_LENGHTH → NAPI_AUTO_LENGTH

@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 30, 2022
@addaleaxaddaleax added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jan 30, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42247/

@github-actionsgithub-actionsBot mentioned this pull request Jan 31, 2022
Open
28 tasks
@MesteeryMesteery added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41764
✔ Done loading data for nodejs/node/pull/41764
----------------------------------- PR info ------------------------------------
Title src: fix typo in js_native_api_v8.cc (#41764)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch caioagiani:patch-1 -> nodejs:master
Labels c++
Commits 1
- src: fix typo in js_native_api_v8.cc
Committers 1
- caioagiani PR-URL: https://github.com/nodejs/node/pull/41764
Reviewed-By: Mestery Reviewed-By: Anna Henningsen Reviewed-By: Darshan Sen Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41764
Reviewed-By: Mestery Reviewed-By: Anna Henningsen Reviewed-By: Darshan Sen Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 30 Jan 2022 03:46:18 GMT
✔ Approvals: 8
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41764#pullrequestreview-867072126
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41764#pullrequestreview-867091112
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867094356
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867110760
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867193237
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867199780
✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41764#pullrequestreview-867235295
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41764#pullrequestreview-868370661
✖ This PR needs to wait 6 more hours to land
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-01-30T19:05:07Z: https://ci.nodejs.org/job/node-test-pull-request/42247/
- Querying data for job/node-test-pull-request/42247/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1774881296

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 31, 2022
This was referenced Feb 1, 2022
Open
Open
@gengjiawengengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 4318b23 into nodejs:masterFeb 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4318b23

@github-actionsgithub-actionsBot mentioned this pull request Feb 3, 2022
Open
41 tasks
@github-actionsgithub-actionsBot mentioned this pull request Feb 4, 2022
Open
38 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@caioagiani@ruyadorno
src: fix typo in js_native_api_v8.cc
bbfa586
PR-URL: #41764
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@caioagiani@danielleadams
src: fix typo in js_native_api_v8.cc
339b0e2
PR-URL: #41764
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@caioagiani@danielleadams
src: fix typo in js_native_api_v8.cc
50fd475
PR-URL: #41764
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@caioagiani@danielleadams
src: fix typo in js_native_api_v8.cc
1cfc63e
PR-URL: #41764
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+2 more reviewers
@MesteeryMesteeryMesteery approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@caioagiani@nodejs-github-bot@addaleax@lpinca@cjihrig@tniessen@gengjiawen@richardlau@RaisinTen@Mesteery@VoltrexKeyva