Skip to content

benchmark: use Object.hasOwn() instead of hasOwnProperty() - #41769

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:hasOwn2
Jan 31, 2022
Merged

benchmark: use Object.hasOwn() instead of hasOwnProperty()#41769
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:hasOwn2

Conversation

@Trott

@TrottTrott commented Jan 30, 2022

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Jan 30, 2022
@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. and removed http Issues or PRs related to the http subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 30, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@TrottTrott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 30, 2022
@github-actions

github-actionsBot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@benjamingrbenjamingr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42244/

@benjamingr

benjamingr commented Jan 30, 2022

Copy link
Copy Markdown
Member

(Ci doesn't test benchmarks so I assume this is to please commit-queue?)

@Trott

Trott commented Jan 30, 2022

Copy link
Copy Markdown
MemberAuthor

(Ci doesn't test benchmarks so I assume this is to please commit-queue?)

CI does test benchmarks.

https://ci.nodejs.org/job/node-test-commit-linux/44499/nodes=ubuntu1804-64/console

06:46:50 ok 3382 benchmark/test-benchmark-assert
06:46:51 ---
06:46:51 duration_ms: 1.112
06:46:51 ...
06:46:51 ok 3383 benchmark/test-benchmark-async-hooks
06:46:52 ---
06:46:52 duration_ms: 0.910
06:46:52 ...
06:46:52 ok 3384 benchmark/test-benchmark-buffer
06:46:55 ---
06:46:55 duration_ms: 3.114

@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42255/

@github-actionsgithub-actionsBot mentioned this pull request Jan 31, 2022
Open
28 tasks
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 96e81df into nodejs:masterJan 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

Landed in 96e81df

@Trott
Trott deleted the hasOwn2 branch January 31, 2022 02:34
This was referenced Feb 1, 2022
Open
Open
This was referenced Feb 3, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott@ruyadorno
benchmark: use Object.hasOwn() instead of hasOwnProperty()
28b95a5
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott@danielleadams
benchmark: use Object.hasOwn() instead of hasOwnProperty()
96b7289
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott@danielleadams
benchmark: use Object.hasOwn() instead of hasOwnProperty()
a1127fc
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott@danielleadams
benchmark: use Object.hasOwn() instead of hasOwnProperty()
2c566a9
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
+1 more reviewer
@MesteeryMesteeryMesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@benjamingr@addaleax@Mesteery@aduh95