Skip to content

doc: use Object.hasOwn() in util doc - #41780

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:hasowndoc
Jan 31, 2022
Merged

doc: use Object.hasOwn() in util doc#41780
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:hasowndoc

Conversation

@Trott

Copy link
Copy Markdown
Member

Swtich from hasOwnProperty() to Object.hasOwn().

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Jan 31, 2022
@TrottTrott added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. labels Jan 31, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
@TrottTrott changed the title doc: use Objec t.hasOwn in util docdoc: use Object.hasOwn() in util docJan 31, 2022

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume this is for the eslint rule to run on the docs?

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 31, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 4fbe9e5 into nodejs:masterJan 31, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 4fbe9e5

@Trott
Trott deleted the hasowndoc branch January 31, 2022 22:33
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
PR-URL: #41780
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@benjamingr@aduh95@Mesteery