Skip to content

doc: align tls port types with net port types - #41799

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-tls-align-port-type-integer-with-net
Feb 2, 2022
Merged

doc: align tls port types with net port types#41799
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-tls-align-port-type-integer-with-net

Conversation

@tniessen

@tniessentniessen commented Jan 31, 2022

Copy link
Copy Markdown
Member

Make the localPort and remotePort properties in tls.md match those in net.md, i.e., change their types from number to integer.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jan 31, 2022
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit cd5689e into nodejs:masterFeb 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in cd5689e

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen@ruyadorno
doc: align tls port types with net port types
4eb1938
PR-URL: #41799
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen@danielleadams
doc: align tls port types with net port types
ede0d69
PR-URL: #41799
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen@danielleadams
doc: align tls port types with net port types
c5a3bf7
PR-URL: #41799
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen@danielleadams
doc: align tls port types with net port types
4660c1f
PR-URL: #41799
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@MesteeryMesteeryMesteery approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tniessen@nodejs-github-bot@benjamingr@lpinca@cjihrig@Mesteery@VoltrexKeyva