Skip to content

doc: add format-md step to release guide - #41809

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
danielleadams:da/add-format-step-to-release
Feb 1, 2022
Merged

doc: add format-md step to release guide#41809
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
danielleadams:da/add-format-step-to-release

Conversation

@danielleadams

Copy link
Copy Markdown
Contributor

Adds a note in the release guides to run markdown formatter before creating a release commit.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 1, 2022
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2022
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit c51494e into nodejs:masterFeb 1, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c51494e

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41809
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
danielleadams added a commit that referenced this pull request Mar 2, 2022
PR-URL: #41809
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams added a commit that referenced this pull request Mar 3, 2022
PR-URL: #41809
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams
danielleadams deleted the da/add-format-step-to-release branch March 4, 2022 14:29
danielleadams added a commit that referenced this pull request Mar 14, 2022
PR-URL: #41809
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@danielleadams@nodejs-github-bot@Trott@lpinca@cjihrig@tniessen@richardlau@aduh95@RaisinTen@Mesteery