Skip to content

test: exclude ibm i tests until we resolve - #41812

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:ibmi-excludes
Closed

test: exclude ibm i tests until we resolve#41812
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:ibmi-excludes

Conversation

@mhdawson

@mhdawsonmhdawson commented Feb 1, 2022

Copy link
Copy Markdown
Member

Refs: #39683

These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson
test: exclude ibm i tests until we resolve
fa8d822
Refs: nodejs#39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 1, 2022
@richardlaurichardlau added the ibm i Issues and PRs related to the IBM i platform. label Feb 1, 2022
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2022
@github-actions

github-actionsBot commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42307/

@mhdawson

mhdawson commented Feb 1, 2022

Copy link
Copy Markdown
MemberAuthor

Going to land based on fast track.

mhdawson added a commit that referenced this pull request Feb 1, 2022
@mhdawson
test: exclude ibm i tests until we resolve
1387bb5
Refs: #39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@mhdawson

mhdawson commented Feb 1, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in 1387bb5

@mhdawsonmhdawson closed this Feb 1, 2022
@mhdawsonmhdawson mentioned this pull request Feb 1, 2022
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson@ruyadorno
test: exclude ibm i tests until we resolve
ea96640
Refs: #39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
richardlau added a commit to richardlau/node-1 that referenced this pull request Feb 15, 2022
@richardlau
test: fix names of tests marked flaky on IBM i
e2db643
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: nodejs#41812
Refs: nodejs#39683
@richardlaurichardlau mentioned this pull request Feb 15, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Feb 15, 2022
@richardlau
test: fix names of tests marked flaky on IBM i
bbd7cf7
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: #41812
Refs: #39683
PR-URL: #41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@richardlau@bengl
test: fix names of tests marked flaky on IBM i
6034944
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: nodejs#41812
Refs: nodejs#39683
PR-URL: nodejs#41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@richardlau@bengl
test: fix names of tests marked flaky on IBM i
702b6ca
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: nodejs#41812
Refs: nodejs#39683
PR-URL: nodejs#41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
bengl pushed a commit that referenced this pull request Feb 21, 2022
@richardlau@bengl
test: fix names of tests marked flaky on IBM i
dfed498
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: #41812
Refs: #39683
PR-URL: #41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
bengl pushed a commit that referenced this pull request Feb 22, 2022
@richardlau@bengl
test: fix names of tests marked flaky on IBM i
f8e302c
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: #41812
Refs: #39683
PR-URL: #41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson@danielleadams
test: exclude ibm i tests until we resolve
0907c1b
Refs: #39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson@danielleadams
test: exclude ibm i tests until we resolve
f39d1bb
Refs: #39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson@danielleadams
test: exclude ibm i tests until we resolve
3690d34
Refs: #39683
These are being worked, but we really should have
marked flaky a long time ago in ordert to make
then nightlies non-red.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 21, 2022
@richardlau@danielleadams
test: fix names of tests marked flaky on IBM i
e5b4c53
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: #41812
Refs: #39683
PR-URL: #41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Apr 24, 2022
@richardlau@danielleadams
test: fix names of tests marked flaky on IBM i
711e863
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: #41812
Refs: #39683
PR-URL: #41984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.ibm iIssues and PRs related to the IBM i platform.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mhdawson@nodejs-github-bot@Trott@cjihrig@richardlau@VoltrexKeyva