Uh oh!
There was an error while loading. Please reload this page.
[v16 backport] deps: V8: cherry-pick cc9a8a37445e - #41825
Closed
devsnek wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Feb 2, 2022
Collaborator
Review requested:
|
This comment has been minimized.
This comment has been minimized.
Original commit message: fix overflow check in error formatting Bug: v8:12494 Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Gus Caplan <snek@chromium.org> Cr-Commit-Position: refs/heads/main@{#78909} Refs: v8/v8@cc9a8a3
devsnekforce-pushed
the
cherrypick-41823-16x
branch
from
February 2, 2022 19:26
bd2127a to
7e9aeb0Comparenodejs-github-bot
commented
Feb 2, 2022
Collaborator
41 tasks
gengjiawen
approved these changes
Feb 3, 2022
devsnek
commented
Feb 3, 2022
MemberAuthor
Is the js linter expected to fail? I only changed c++ code in deps/v8... |
targos
commented
Feb 3, 2022
Member
Yes, it will be fixed by #41805 |
This was referenced Feb 4, 2022
danielleadams pushed a commit
that referenced
this pull request
Feb 5, 2022
Original commit message: fix overflow check in error formatting Bug: v8:12494 Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Gus Caplan <snek@chromium.org> Cr-Commit-Position: refs/heads/main@{#78909} Refs: v8/v8@cc9a8a3 PR-URL: #41825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
commented
Feb 5, 2022
Contributor
Landed in ebc370c |
27 tasks
Merged
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@cc9a8a3