Uh oh!
There was an error while loading. Please reload this page.
doc: update AUTHORS list - #4183
Conversation
evanlucas
commented
Dec 8, 2015
@rvagg All 3 are me. I prefer evanlucas@me.com. Sorry for the confusion on that |
hellopao
commented
Dec 8, 2015
@rvagg you can list me as "Jerry Chin", tks! |
rvagg
commented
Dec 8, 2015
@jkrems you are listed with two different email addresses, see .mailmap in this PR, I've consolidated you under your gmail, which would you prefer? @evanlucas no problems at all, that's what .mailmap is for. @hellopao done, thanks! |
hybrist
commented
Dec 8, 2015
@rvagg Gmail is the preferred one. Guess I messed up my git config for that other commit. |
calebboyd
commented
Dec 8, 2015
@rvagg, You can list me as "Caleb Boyd". Thanks! |
svenheden
commented
Dec 8, 2015
You can list me as Jonathan Persson and with my gmail persson.jonathan@gmail.com, thanks! |
Martii
commented
Dec 8, 2015
Marti Martz Appreciate the acknowledgement for my tiny little contribution. :) P.S. Thanks to your team for all they do. |
rvagg
commented
Dec 8, 2015
@jkrems done |
rvagg
commented
Dec 8, 2015
@calebboyd done |
john-yan
commented
Dec 8, 2015
Hello @rvagg , could you plz put both of my emails, john.yan1019@gmail.com and jyan@ca.ibm.com? since I couldn't be able to check email while I am not able to connect to the IBM internal network. Thanks! |
rvagg
commented
Dec 8, 2015
thanks @john-yan, I've updated .mailmap to use your gmail.com address, see attached commit. |
claudiorodriguez
commented
Dec 8, 2015
That's strange, my github profile has my real name which is Claudio Rodriguez, is that not showing for you? Mail is cjrodr at yahoo dot com |
rvagg
commented
Dec 8, 2015
Thanks @fansworld-claudio, updated. This all comes from git itself, see https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit on how to set up your details in your local .gitconfig which is what determines what goes into your commit log. |
MJefferson
commented
Dec 8, 2015
Appreciate the love Rod. Please list me as Martial James Jefferson. Best, Thanks On Tue, Dec 8, 2015 at 12:56 AM, Rod Vagg notifications@github.com wrote:
|
SPGB
commented
Dec 8, 2015
Hi @rvagg, my preference is samgallagherb@gmail.com. Thanks |
Zirak
commented
Dec 8, 2015
Hurray, virtual fame for life! @rvagg Zirak and zirakertan@gmail.com (what you currently have) are more than fine. Thanks for the consideration. |
dbkaplun
commented
Dec 9, 2015
Hi @rvagg, can you update my email address to dbkaplun@gmail.com please? (Dan Kaplun) |
rvagg
commented
Dec 10, 2015
9c76a40 to
b2863f9Comparervagg
commented
Dec 10, 2015
@hemanth you are listed here as "Hemanth.HM" due to your git settings. Most of us have a full name listed, would you like to have yours adjusted or are you happy with how it is? |
dbkaplun
commented
Dec 10, 2015
@rvagg thanks! (BTW I don't have the other email address anymore so the line in |
rvagg
commented
Dec 10, 2015
Friendly reminder to @pflannery, @bcbcb, @wizicer, @jimmyhsu, @stcruy, @DannyNemer@baslr who may have been asked before: your entry in AUTHORS is listed with a GitHub noreply address. Most of us have a real email address listed and it is helpful to the project, if for example in the future we need to adjust licensing terms, however it's by no means mandatory if you'd prefer to not list an address. If you would like it changed, please let me know and I can update your entry. |
ghost
commented
Dec 10, 2015
@wurde is Andy Bettisworth, hi! andy.bettisworth@accreu.com |
hemanth
commented
Dec 10, 2015
@rvagg Thank for asking, I am happy with |
wizicer
commented
Dec 10, 2015
Thanks @rvagg for the reminder, I'd like to use |
baslr
commented
Dec 10, 2015
@rvagg diff is fine. |
jasnell
commented
Dec 11, 2015
Once all the author metadata is updated, this LGTM Awesome to see so many names being added! |
Update AUTHORS list using tools/update-authors.sh
jasnell
commented
Dec 14, 2015
@rvagg ... is this about ready? |
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
commented
Dec 15, 2015
done, 59 new authors since last time I did this 2 months ago @ 0116da1! |
rvagg
commented
Dec 15, 2015
hemanth
commented
Dec 15, 2015
👍 |
jasnell
commented
Dec 15, 2015
That's fantastic! Thanks @rvagg!
|
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <jasnell@gmail.com>
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <jasnell@gmail.com>
jimmyhsu
commented
Jan 6, 2016
@rvagg Apologies for being so late. I've been busy and didn't notice this until now. Might be too late, but my email for contact is jimmyhsu+github@live.com. If there's another ticket open for this let me know and I can post it there as I didn't realize it was a github noreply email prior to this. |
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <jasnell@gmail.com>
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs#4183 Reviewed-By: James M Snell <jasnell@gmail.com>
Update AUTHORS list using tools/update-authors.sh
This is a big 'un! We need some input from some individuals this pulls in wrt their details: