Skip to content

doc: copyedit addons doc - #4185

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:addons
Closed

doc: copyedit addons doc#4185
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:addons

Conversation

@Trott

@TrottTrott commented Dec 8, 2015

Copy link
Copy Markdown
Member

No description provided.

@TrottTrott added the doc Issues and PRs related to the documentations. label Dec 8, 2015
@mscdexmscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 8, 2015
@targos

Copy link
Copy Markdown
Member

LGTM

Comment threaddoc/api/addons.markdown Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'The most important class is node::ObjectWrap' ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good to me.

@silverwind

Copy link
Copy Markdown
Contributor

LGTM with suggestion.

Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2015
PR-URL: nodejs#4185
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in e3187cc

@TrottTrott closed this Dec 10, 2015
Trott added a commit that referenced this pull request Dec 15, 2015
PR-URL: #4185
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@rvaggrvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
PR-URL: #4185
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4185
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4185
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott
Trott deleted the addons branch January 13, 2022 22:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@targos@silverwind@mscdex@jasnell@MylesBorins