Uh oh!
There was an error while loading. Please reload this page.
test: remove test-worker-memory flaky designation - #41867
Merged
Conversation
tniessen
approved these changes
Feb 5, 2022
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
27 tasks
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Feb 6, 2022
Collaborator
Mesteery
approved these changes
Feb 6, 2022
lpinca
approved these changes
Feb 6, 2022
benjamingr
approved these changes
Feb 6, 2022
nodejs-github-bot
commented
Feb 6, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41867 ✔ Done loading data for nodejs/node/pull/41867 ----------------------------------- PR info ------------------------------------ Title test: remove test-worker-memory flaky designation (#41867) Author Rich Trott (@Trott) Branch Trott:deflake-test-worker-memory -> nodejs:master Labels test, fast-track, needs-ci Commits 1 - test: remove test-worker-memory flaky designation Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41867 Fixes: https://github.com/nodejs/node/issues/23277 Reviewed-By: Tobias Nießen Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41867 Fixes: https://github.com/nodejs/node/issues/23277 Reviewed-By: Tobias Nießen Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 05 Feb 2022 21:19:26 GMT ✔ Approvals: 4 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41867#pullrequestreview-873971527 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41867#pullrequestreview-873982821 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41867#pullrequestreview-873995238 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41867#pullrequestreview-874003309 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Last Full PR CI on 2022-02-06T01:37:00Z: https://ci.nodejs.org/job/node-test-pull-request/42385/ - Querying data for job/node-test-pull-request/42385/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1802453772 |
Trott
commented
Feb 6, 2022
MemberAuthor
It now occurs to me: The test is marked as flaky so would failures even show up there? I don't think it would. So I need to find another way to look for recent failures or else run a stress test. |
Trott
commented
Feb 6, 2022
MemberAuthor
I just manually went through every unstable Windows CI job for the past month and didn't see this one come up a single time. Now landing. |
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: nodejs#23277 PR-URL: nodejs#41867Fixes: nodejs#23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trottforce-pushed
the
deflake-test-worker-memory
branch
from
February 6, 2022 14:23
d809894 to
30bdee2CompareTrott
commented
Feb 6, 2022
MemberAuthor
Landed in 30bdee2 |
This was referenced Feb 7, 2022
ruyadorno pushed a commit
that referenced
this pull request
Feb 8, 2022
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: #23277 PR-URL: #41867Fixes: #23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Feb 9, 2022
danielleadams pushed a commit
that referenced
this pull request
Mar 2, 2022
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: #23277 PR-URL: #41867Fixes: #23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 3, 2022
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: #23277 PR-URL: #41867Fixes: #23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: nodejs#23277 PR-URL: nodejs#41867Fixes: nodejs#23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 8, 2022
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: #23277 PR-URL: #41867Fixes: #23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 14, 2022
Judging from https://github.com/nodejs/reliability/issues, this hasn't failed in CI since November 2021. Closes: #23277 PR-URL: #41867Fixes: #23277 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judging from https://github.com/nodejs/reliability/issues, this hasn't
failed in CI since November 2021.
Closes: #23277