Skip to content

License builder tool - #4194

Merged
rvagg merged 2 commits into
nodejs:masterfrom
rvagg:license-builder
Jan 14, 2016
Merged

License builder tool#4194
rvagg merged 2 commits into
nodejs:masterfrom
rvagg:license-builder

Conversation

@rvagg

@rvaggrvagg commented Dec 8, 2015

Copy link
Copy Markdown
Member

Added tools/license-builder.sh to construct the LICENSE file from the licenses of all the dependencies used by Node.

Re-ordered the licenses alphabetically within dependency type groups:

  • Dependencies bundled in Node.js
    • C-Ares
    • HTTP Parser
    • ICU
    • libuv
    • OpenSSL
    • Punycode.js
    • V8
    • libuv (newly included)
  • npm
  • Build tools
    • GYP
    • marked
  • Test tools
    • cpplint.py
    • ESLint
    • gtest
    • node-weak

Additionally:

  • Cleaned up naming to be consistent with what each of these projects appear to want to be called.
  • Made the lead for each license consistent NAME, located at LOCATION, is licensed as follows:
  • Stripped out comment syntax, HTML and other unnecessary guff from licenses that have them (e.g. where they are included in source files and need it to be in comments)

It's surprising how far out of sync we are with our dependency licenses cause we don't have a tool or procedure to keep them updated.

This probably needs to wait at least until we get results from #3979 but I'd like us to have a tool that keeps our rules consistent and lets us ensure our LICENSE is up to date.

/cc @mikeal

@rvagg

rvagg commented Dec 8, 2015

Copy link
Copy Markdown
MemberAuthor

renamed "C-Ares" to "c-ares", realised that I can't find reference to that capitalisation on the internet

@mscdexmscdex added the meta Issues and PRs related to the general management of the project. label Dec 8, 2015
@jasnell

Copy link
Copy Markdown
Member

Rubber stamp LGTM

@rvagg

Copy link
Copy Markdown
MemberAuthor

@nodejs/ctc anyone want to weigh in here? the work here is for consistency (lots of variation in how licenses are introduced and presented) and completeness (some are missing) with a bit of reordering according to the grouping above. I haven't touched the top bit, leaving that for when we finally get legal advice on it but tbh I'm not holding my breath for that happening. Once we have a tool in place, we can adjust it according to any official advice we get from lawyers.

@jasnell

Copy link
Copy Markdown
Member

Nothing further really. Let's get the PR landed and get the tool in place, we can tweak and iterate from there.

@Fishrock123

Copy link
Copy Markdown
Contributor

rubber-stamp lgtm

PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg added a commit that referenced this pull request Jan 14, 2016
PR-URL: #4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg added a commit that referenced this pull request Jan 14, 2016
PR-URL: #4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg

Copy link
Copy Markdown
MemberAuthor

Landed @ 031b87d & d91646b, improvements can come via PR.

OSX installer is as ugly as ever, no surprises there

screen shot 2016-01-14 at 11 19 45 pm

The Windows installer is meant to use an RTF rendering of this doc, hence the additional formatting in there. I don't have a Windows machine handy right now due to a big office cleanup, could someone from @nodejs/platform-windows please grab an msi from https://nodejs.org/download/nightly/v5.4.2-nightly20160114e855b596f4/ and screenshot the license screen for us?

@rvagg

Copy link
Copy Markdown
MemberAuthor

fwiw I'm hoping we can deal with the OSX formatting along with #2571 but I haven't looked at it yet (which is why it's still in limbo!)

@seishun

Copy link
Copy Markdown
Contributor

@rvagg This one?
nodelicense

@rvagg

Copy link
Copy Markdown
MemberAuthor

Yep, that looks OK I think @seishun, if you do a scroll through does it look ok (as far as these things go), i.e. proper formatting rather than markdown?

@seishun

Copy link
Copy Markdown
Contributor

Does this count as proper formatting?
license2
Otherwise everything looks ok.

@rvagg

Copy link
Copy Markdown
MemberAuthor

bah, that doesn't look right .. probably need to tweak either the LICENSE.md format or the rtf converter.

Will leave this issue open as a reminder, to myself or anyone else wanting to tackle this job (hint: ./tools/license2rtf.js).

@rvagg

Copy link
Copy Markdown
MemberAuthor

and thanks for being responsive on this @seishun!

@rvagg
rvagg merged commit d91646b into nodejs:masterJan 14, 2016
rvagg added a commit that referenced this pull request Jan 28, 2016
PR-URL: #4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg added a commit that referenced this pull request Jan 28, 2016
PR-URL: #4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
PR-URL: #4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
PR-URL: #4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 11, 2016
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rvagg@jasnell@Fishrock123@seishun@mscdex@MylesBorins