Uh oh!
There was an error while loading. Please reload this page.
doc: fixup socket.remoteAddress - #4198
Closed
baloo wants to merge 1 commit into
Closed
Conversation
Member
There was a problem hiding this comment.
The parenthetical seems confusing more than clarifying. I would say either remove it, or change it to be more explicit: (for example, if the client disconnected)
remoteAddress may be undefined under certain conditions Signed-off-by: Arthur Gautier <baloo@gandi.net>
baloo
commented
Dec 8, 2015
ContributorAuthor
@Trott fixed thanks |
evanlucas
commented
Dec 8, 2015
Contributor
LGTM |
baloo pushed a commit
to baloo/forwarded
that referenced
this pull request
Dec 9, 2015
see nodejs/node#4198 test case: ``` javascript var net = require('net'); var server = net.createServer(function(c) { //'connection' listener c.on('end', function() { console.log(c.remoteAddress); server.close(); }); }); server.listen(8124, function() { var client = net.connect({port: 8124}, function(c) { client.end(); }); }); ``` Signed-off-by: Arthur Gautier <baloo@gandi.net>
baloo pushed a commit
to baloo/forwarded
that referenced
this pull request
Dec 9, 2015
see nodejs/node#4198 test case: ``` javascript var net = require('net'); var server = net.createServer(function(c) { //'connection' listener c.on('end', function() { console.log(c.remoteAddress); server.close(); }); }); server.listen(8124, function() { var client = net.connect({port: 8124}, function(c) { client.end(); }); }); ``` Signed-off-by: Arthur Gautier <baloo@gandi.net>
jasnell
commented
Dec 11, 2015
Member
LGTM |
rvagg pushed a commit
that referenced
this pull request
Dec 14, 2015
remoteAddress may be undefined under certain conditions Signed-off-by: Arthur Gautier <baloo@gandi.net> PR-URL: #4198 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg
commented
Dec 14, 2015
Member
cjihrig pushed a commit
that referenced
this pull request
Dec 15, 2015
remoteAddress may be undefined under certain conditions Signed-off-by: Arthur Gautier <baloo@gandi.net> PR-URL: #4198 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 29, 2015
remoteAddress may be undefined under certain conditions Signed-off-by: Arthur Gautier <baloo@gandi.net> PR-URL: #4198 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
remoteAddress may be undefined under certain conditions Signed-off-by: Arthur Gautier <baloo@gandi.net> PR-URL: #4198 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
remoteAddress may be undefined under certain conditions Signed-off-by: Arthur Gautier <baloo@gandi.net> PR-URL: nodejs#4198 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remoteAddress may be undefined under certain conditions