deps: update V8 to 10.2 by targos · Pull Request #42115 · nodejs/node

targos · 2022-02-24T13:54:11Z

ETA: Tue, Mar 1, 2022

nodejs-github-bot · 2022-02-24T13:54:15Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2022-02-24T13:55:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42764/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4530/

targos · 2022-02-24T14:12:49Z

New Windows failure, as usual 😞

Details

15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xutility(4198,16): error C2280: 'std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> &std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>::operator =(const std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> &)': attempting to reference a deleted function [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3270): message : see declaration of 'std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>::operator =' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3270,17): message : 'std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> &std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>::operator =(const std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> &)': function was explicitly deleted [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1175): message : see reference to function template instantiation '_OutIt *std::_Copy_unchecked<_Iter,std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>*>(_InIt,_InIt,_OutIt)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 with
15:01:51 [
15:01:51 _OutIt=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *,
15:01:51 _Iter=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *,
15:01:51 _InIt=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *
15:01:51 ]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1189): message : see reference to function template instantiation 'void std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>::_Assign_range<_Iter>(_Iter,_Iter,std::forward_iterator_tag)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 with
15:01:51 [
15:01:51 _Iter=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *
15:01:51 ]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1189): message : see reference to function template instantiation 'void std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>::_Assign_range<_Iter>(_Iter,_Iter,std::forward_iterator_tag)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 with
15:01:51 [
15:01:51 _Iter=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *
15:01:51 ]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1200): message : see reference to function template instantiation 'void std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>::assign<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>*,0>(_Iter,_Iter)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 with
15:01:51 [
15:01:51 _Iter=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *
15:01:51 ]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1200): message : see reference to function template instantiation 'void std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>::assign<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>*,0>(_Iter,_Iter)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 with
15:01:51 [
15:01:51 _Iter=std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>> *
15:01:51 ]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1197): message : while compiling class template member function 'void std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>::_Copy_assign(const std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>> &,std::false_type)' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1216): message : see reference to function template instantiation 'void std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>::_Copy_assign(const std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>> &,std::false_type)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
15:01:51 C:\workspace\node-compile-windows\node\deps\v8\include\cppgc\heap.h(126): message : see reference to class template instantiation 'std::vector<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>,std::allocator<std::unique_ptr<cppgc::CustomSpaceBase,std::default_delete<cppgc::CustomSpaceBase>>>>' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

targos · 2022-02-25T10:29:35Z

I created a V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=12661

targos · 2022-03-01T08:21:54Z

Anyone knows how we could work around the Windows error?

bnoordhuis · 2022-03-01T16:24:34Z

Untested, but does this diff work?

diff --git a/include/cppgc/heap.h b/include/cppgc/heap.h
index 136c4fb44d..e677bb2845 100644
--- a/include/cppgc/heap.h+++ b/include/cppgc/heap.h@@ -111,13 +111,6 @@ class V8_EXPORT Heap {
* heap through `Heap::Create()`.
*/
struct HeapOptions {
- /**- * Creates reasonable defaults for instantiating a Heap.- *- * \returns the HeapOptions that can be passed to `Heap::Create()`.- */- static HeapOptions Default() { return {}; }-
/**
* Custom spaces added to heap are required to have indices forming a
* numbered sequence starting at 0, i.e., their `kSpaceIndex` must
@@ -161,7 +154,7 @@ class V8_EXPORT Heap {
*/
static std::unique_ptr<Heap> Create(
std::shared_ptr<Platform> platform,
- HeapOptions options = HeapOptions::Default());+ HeapOptions options = {});
virtual ~Heap() = default;

I think the compiler is allowed to fail here because it's not required to apply copy elision in Default().

targos · 2022-03-01T17:15:28Z

Let's try it!

nodejs-github-bot · 2022-03-01T17:17:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42831/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4536/

targos · 2022-03-01T17:23:28Z

@bnoordhuis GCC doesn't like it:

18:22:24 ../deps/v8/include/cppgc/heap.h:157:30: error: could not convert '<brace-enclosed initializer list>()' from '<brace-enclosed initializer list>' to 'cppgc::Heap::HeapOptions'
18:22:24 HeapOptions options = {});
18:22:24 ^

targos · 2022-03-01T17:27:35Z

Also, MSVC still gives the same error as before, I think.

bnoordhuis · 2022-03-01T20:27:02Z

Maybe msvc is tripping over its own auto-generated copy constructors. Does explicitly deleting them help?

diff --git a/include/cppgc/heap.h b/include/cppgc/heap.h
index 136c4fb44d..23c1756abb 100644
--- a/include/cppgc/heap.h+++ b/include/cppgc/heap.h@@ -150,6 +150,9 @@ class V8_EXPORT Heap {
* GC scheduler follows.
*/
ResourceConstraints resource_constraints;
++ HeapOptions(const HeapOptions&) = delete;+ void operator=(const HeapOptions&) = delete;
};
/**
diff --git a/include/v8-cppgc.h b/include/v8-cppgc.h
index af21054e2b..7d11c245c7 100644
--- a/include/v8-cppgc.h+++ b/include/v8-cppgc.h@@ -80,6 +80,9 @@ struct WrapperDescriptor final {
struct V8_EXPORT CppHeapCreateParams {
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
WrapperDescriptor wrapper_descriptor;
++ CppHeapCreateParams(const CppHeapCreateParams&) = delete;+ void operator=(const CppHeapCreateParams&) = delete;
};
/**

The gcc error can probably be fixed by writing HeapOptions options = HeapOptions().

targos · 2022-03-02T07:51:49Z

That error is gone, thanks!

Now we have:

 Checking inspector protocol compatibility, and also Generating inspector protocol sources from protocol json
Traceback (most recent call last):
File "D:\a\node\node\deps\v8\third_party\inspector_protocol\code_generator.py", line 702, in <module>
main()
File "D:\a\node\node\deps\v8\third_party\inspector_protocol\code_generator.py", line 572, in main
protocol = Protocol(config)
File "D:\a\node\node\deps\v8\third_party\inspector_protocol\code_generator.py", line 360, in __init__
self.generate_domains = self.read_protocol_file(config.protocol.path)
AttributeError: 'X' object has no attribute 'path'

I going to investigate on my machine, because 32dd0d7#diff-33f548d8c76be9f5052a98ec2fff58be393ac5b920e0c997227bf17cbb2deaa0R169 was supposed to take care of it.

targos · 2022-03-02T08:05:03Z

The generated argument is wrong:

targos · 2022-03-02T08:37:08Z

Also:

In file included from /usr/include/c++/9/memory:80,
from ../deps/v8/include/cppgc/heap.h:10,
from ../deps/v8/src/heap/cppgc/heap.h:8,
from ../deps/v8/src/heap/cppgc/heap.cc:5:
/usr/include/c++/9/bits/unique_ptr.h: In instantiation of ‘typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = cppgc::internal::Heap; _Args = {std::shared_ptr<cppgc::Platform>, cppgc::Heap::HeapOptions}; typename std::_MakeUniq<_Tp>::__single_object = std::unique_ptr<cppgc::internal::Heap, std::default_delete<cppgc::internal::Heap> >]’:
../deps/v8/src/heap/cppgc/heap.cc:42:61: required from here
/usr/include/c++/9/bits/unique_ptr.h:857:30: error: use of deleted function ‘cppgc::Heap::HeapOptions::HeapOptions(const cppgc::Heap::HeapOptions&)’
857 | { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../deps/v8/src/heap/cppgc/heap.h:8,
from ../deps/v8/src/heap/cppgc/heap.cc:5:
../deps/v8/include/cppgc/heap.h:154:5: note: declared here
154 | HeapOptions(const HeapOptions&) = delete;
| ^~~~~~~~~~~
../deps/v8/src/heap/cppgc/heap.cc:80:37: note: initializing argument 2 of ‘cppgc::internal::Heap::Heap(std::shared_ptr<cppgc::Platform>, cppgc::Heap::HeapOptions)’
80 | cppgc::Heap::HeapOptions options)
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
make[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:1005: /home/runner/work/node/node/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/heap/cppgc/heap.o] Error 1
make[2]: *** Waiting for unfinished jobs....

targos · 2022-03-02T15:39:01Z

The generated argument is wrong:

The problem is the path fixing logic from

node/tools/gyp/pylib/gyp/generator/msvs.py

Line 431 in d50efc6

arguments= [iif (i[:1] in"/-") else_FixPath(i, "/") foriincmd[1:]]

targos · 2022-03-02T15:47:36Z

Same error about the deleted function on windows:

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.31.31103\include\memory(3417,59): error C2280: 'cppgc::Heap::HeapOptions::HeapOptions(const cppgc::Heap::HeapOptions &)' : tentative de référencemen
t d'une fonction supprimée [D:\Git\nodejs\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\Git\nodejs\node\deps\v8\include\cppgc\heap.h(154): message : voir la déclaration de 'cppgc::Heap::HeapOptions::HeapOptions' [D:\Git\nodejs\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\Git\nodejs\node\deps\v8\src\heap\cppgc\heap.cc(42): message : voir la référence à l'instanciation de la fonction modèle 'std::unique_ptr<cppgc::internal::Heap,std::default_delete<cppgc::internal::Heap>> std::make_uniqu
e<cppgc::internal::Heap,std::shared_ptr<cppgc::Platform>,cppgc::Heap::HeapOptions,0>(std::shared_ptr<cppgc::Platform> &&,cppgc::Heap::HeapOptions &&)' en cours de compilation [D:\Git\nodejs\node\tools\v8_gypfiles\v8_base_ without_compiler.vcxproj]
```

jasnell · 2022-03-02T23:48:32Z

FYI: #42192 ... tl;dr 9.9 updates the value serialization format such that any version of Node.js using < 9.9 won't be able to deserialize anything serialized with >= 9.9.

targos · 2022-03-08T06:59:38Z

@gengjiawen Do you have any idea about a magical workaround?

gengjiawen · 2022-03-08T09:54:08Z

@gengjiawen Do you have any idea about a magical workaround?

I should have time on weekends. But I need a windows vm if this not fixed this at that time.

gengjiawen · 2022-03-17T09:46:06Z

@targos Please try, I have verified on vs2022. I will upstream it later.

diff --git a/deps/v8/include/v8-cppgc.h b/deps/v8/include/v8-cppgc.h
index af21054e2b..43be774632 100644
--- a/deps/v8/include/v8-cppgc.h+++ b/deps/v8/include/v8-cppgc.h@@ -78,6 +78,9 @@ struct WrapperDescriptor final {
};
struct V8_EXPORT CppHeapCreateParams {
+ CppHeapCreateParams(const CppHeapCreateParams&) = delete;+ CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;+
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
WrapperDescriptor wrapper_descriptor;
}

targos · 2022-04-06T06:26:30Z

I opened nodejs/gyp-next#143 for the GYP fix.

They are probably not paths, and V8 uses an argument like that, so the fix is needed in Node.js Refs: nodejs/node#42115

Since v8 10.1 v8::External::New DCHECKs that the data passed into it cannot be a nullptr because that's not serializable as external references. This updates the test to pass a dummy data pointer to the call - which does not matter for the test since we only care about whether the finalizer is called. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234 PR-URL: #42532 Refs: #42115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Original commit message: [ic] use CSA_DCHECK in CodeStubAssembler::SharedValueBarrier Since the code is generated unconditionally, using a DCHECK to check that shared RO heap is enabled breaks builds with v8_enable_shared_ro_heap set to false, this patch turns that into a CSA_DCHECK so it only crashes when V8 actually attempts to store into a shared struct while the RO heap isn't shared at run time. Refs: nodejs#42115 Bug: v8:12547 Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#79756} Refs: v8/v8@87ce4f5

Original commit message: [ic] use CSA_DCHECK in CodeStubAssembler::SharedValueBarrier Since the code is generated unconditionally, using a DCHECK to check that shared RO heap is enabled breaks builds with v8_enable_shared_ro_heap set to false, this patch turns that into a CSA_DCHECK so it only crashes when V8 actually attempts to store into a shared struct while the RO heap isn't shared at run time. Refs: #42115 Bug: v8:12547 Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#79756} Refs: v8/v8@87ce4f5 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

targos · 2022-04-14T15:13:47Z

#42740

Since v8 10.1 v8::External::New DCHECKs that the data passed into it cannot be a nullptr because that's not serializable as external references. This updates the test to pass a dummy data pointer to the call - which does not matter for the test since we only care about whether the finalizer is called. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234 PR-URL: nodejs#42532 Refs: nodejs#42115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Original commit message: [ic] use CSA_DCHECK in CodeStubAssembler::SharedValueBarrier Since the code is generated unconditionally, using a DCHECK to check that shared RO heap is enabled breaks builds with v8_enable_shared_ro_heap set to false, this patch turns that into a CSA_DCHECK so it only crashes when V8 actually attempts to store into a shared struct while the RO heap isn't shared at run time. Refs: nodejs#42115 Bug: v8:12547 Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#79756} Refs: v8/v8@87ce4f5 PR-URL: nodejs#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

joyeecheung · 2022-04-25T13:51:36Z

This seems to break --v8-non-optimized-debug, I got it to compile again with this (taken from this CL which is in 10.3: https://chromium-review.googlesource.com/c/v8/v8/+/3585943)

diff --git a/deps/v8/src/codegen/register.h b/deps/v8/src/codegen/register.h
index e36e4d1e9a..ef5f6dfcf7 100644
--- a/deps/v8/src/codegen/register.h+++ b/deps/v8/src/codegen/register.h@@ -26,7 +26,8 @@ template <typename... RegTypes,
std::conjunction_v<std::is_same<Register, RegTypes>...> ||
std::conjunction_v<std::is_same<DoubleRegister, RegTypes>...>>>
inline constexpr bool AreAliased(RegTypes... regs) {
- int num_different_regs = RegListBase{regs...}.Count();+ using FirstRegType = std::tuple_element_t<0, std::tuple<RegTypes...>>;+ int num_different_regs = RegListBase<FirstRegType>{regs...}.Count();
int num_given_regs = (... + (regs.is_valid() ? 1 : 0));
return num_different_regs < num_given_regs;
}

Since the code is generated unconditionally, using a DCHECK to check that shared RO heap is enabled breaks builds with v8_enable_shared_ro_heap set to false, this patch turns that into a CSA_DCHECK so it only crashes when V8 actually attempts to store into a shared struct while the RO heap isn't shared at run time. Refs: nodejs/node#42115 Bug: v8:12547 Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#79756}

Since v8 10.1 v8::External::New DCHECKs that the data passed into it cannot be a nullptr because that's not serializable as external references. This updates the test to pass a dummy data pointer to the call - which does not matter for the test since we only care about whether the finalizer is called. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234 PR-URL: #42532 Refs: #42115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Since v8 10.1 v8::External::New DCHECKs that the data passed into it cannot be a nullptr because that's not serializable as external references. This updates the test to pass a dummy data pointer to the call - which does not matter for the test since we only care about whether the finalizer is called. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234 PR-URL: nodejs/node#42532 Refs: nodejs/node#42115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 24, 2022

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Feb 24, 2022

targos force-pushed the v8-99 branch from 02a2ba3 to b02ffa9Compare February 25, 2022 08:04

targos force-pushed the v8-99 branch from b02ffa9 to 4696a55Compare March 1, 2022 17:15

targos force-pushed the v8-99 branch from 643787f to 836ed73Compare March 7, 2022 09:29

targos mentioned this pull request Mar 10, 2022
Node.js Technical Steering Committee (TSC) Meeting 2022-03-10 nodejs/TSC#1184
Closed

gengjiawen mentioned this pull request Mar 11, 2022
access to windows vm nodejs/build#2891
Closed

targos mentioned this pull request Mar 17, 2022
Issues with newer V8 versions #42375
Closed

targos mentioned this pull request Apr 6, 2022
fix(msvs): avoid fixing path for arguments with "=" nodejs/gyp-next#143
Merged

targos added a commit to nodejs/gyp-next that referenced this pull request Apr 6, 2022
fix(msvs): avoid fixing path for arguments with "=" (#143)
7e8f16e
They are probably not paths, and V8 uses an argument like that, so the fix is needed in Node.js Refs: nodejs/node#42115

targos mentioned this pull request Apr 6, 2022
tools: update gyp-next to v0.12.1 #42625
Merged

github-actionsBot mentioned this pull request Apr 7, 2022
CI Reliability 2022-04-07 nodejs/reliability#244
Open
17 tasks

joyeecheung mentioned this pull request Apr 7, 2022
src: fix near heap limit callback #42636
Closed

github-actionsBot mentioned this pull request Apr 8, 2022
CI Reliability 2022-04-08 nodejs/reliability#245
Open
22 tasks

targos marked this pull request as draft April 8, 2022 15:14

github-actionsBot mentioned this pull request Apr 9, 2022
CI Reliability 2022-04-09 nodejs/reliability#246
Open
24 tasks

This was referenced Apr 10, 2022
CI Reliability 2022-04-10 nodejs/reliability#247
Open
CI Reliability 2022-04-11 nodejs/reliability#248
Open
CI Reliability 2022-04-12 nodejs/reliability#249
Open

targos closed this Apr 14, 2022

targos deleted the v8-99 branch April 21, 2022 10:21

Uh oh!

Uh oh!

Conversation

targos commented Feb 24, 2022

Uh oh!

nodejs-github-bot commented Feb 24, 2022

Uh oh!

nodejs-github-bot commented Feb 24, 2022• edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Feb 24, 2022

Uh oh!

targos commented Feb 25, 2022

Uh oh!

targos commented Mar 1, 2022

Uh oh!

bnoordhuis commented Mar 1, 2022

Uh oh!

targos commented Mar 1, 2022

Uh oh!

nodejs-github-bot commented Mar 1, 2022• edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Mar 1, 2022

Uh oh!

targos commented Mar 1, 2022

Uh oh!

bnoordhuis commented Mar 1, 2022

Uh oh!

targos commented Mar 2, 2022

Uh oh!

targos commented Mar 2, 2022

Uh oh!

targos commented Mar 2, 2022

Uh oh!

targos commented Mar 2, 2022

Uh oh!

targos commented Mar 2, 2022

Uh oh!

jasnell commented Mar 2, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Mar 8, 2022

Uh oh!

gengjiawen commented Mar 8, 2022

Uh oh!

gengjiawen commented Mar 17, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Apr 6, 2022

Uh oh!

targos commented Apr 14, 2022

Uh oh!

joyeecheung commented Apr 25, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nodejs-github-bot commented Feb 24, 2022•
edited by targos
Loading

nodejs-github-bot commented Mar 1, 2022•
edited by targos
Loading

jasnell commented Mar 2, 2022•
edited
Loading

gengjiawen commented Mar 17, 2022•
edited
Loading

joyeecheung commented Apr 25, 2022•
edited
Loading