v17.7.1 release proposal by sxa · Pull Request #42285 · nodejs/node

sxa · 2022-03-10T15:25:34Z

2022-03-10, Version 17.7.1 (Current), @BethGriggs prepared by @sxa

Notable Changes

Fixed regression in url.resolve()

This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain @. This issue affected yarn 1. This version reverts the change that introduced the regression.

Commits

[96a9e00fb3] - url: revert fix url.parse() for @hostname (Antoine du Hamel) #42280

This reverts commit 010cb71. Refs: #42279 PR-URL: #42280Fixes: #42279 Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

sxa · 2022-03-10T15:28:59Z

@Trott If you get the chance LMK if you're happy with the wording in the changlog (same as in the description of this PR)

nodejs-github-bot · 2022-03-10T15:31:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42934/

aduh95 · 2022-03-10T15:50:16Z

yarn v1 -> Yarn 1? That's how it's written on https://classic.yarnpkg.com/.

Trott · 2022-03-10T16:54:52Z

@Trott If you get the chance LMK if you're happy with the wording in the changlog (same as in the description of this PR)

Looks good to me. I'll submit a suggestion for some typographical changes, but this is fine to land without my suggestions as far as I'm concerned.

Trott · 2022-03-10T16:56:53Z

Optional non-blocking suggestion:
Suggested change
This release fixes an issue introduced in Node.js v17.7.0 when the url
has @ characters in it, which showed up when using yarn v1. This version
reverts the change that introduced the regression.
This release fixes an issue introduced in Node.js v17.7.0 with some URLs
that contain `@`. This issue affected yarn v1. This version reverts the
change that introduced the regression.

bricss · 2022-03-10T17:12:27Z

Maybe it's possible to pull #42205 into it? 🙄
It has quite nice fixes 🩹

Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: #42285

sxa · 2022-03-10T17:50:01Z

Force pushed with both typographical suggestions :-)
Taking out of draft.

sxa · 2022-03-10T18:54:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42934/

Re-run at https://ci.nodejs.org/job/node-test-commit/52235

SmartOS and OSX failed for some reason in the intiial run, but passed in the re-run
ubuntu1804_sharedlibs_debug_x64 failed on a flake only in the initial run
Fanned arm builds had one failure in the initial run then the machiens all seemed to be having problems on the re-runm but arm32 passed ok in the armv7l branch of node-test-commit-arm so I'm not concerned that we have a real break

BethGriggs · 2022-03-10T19:01:05Z

Release build on 8fe7979: https://ci-release.nodejs.org/job/iojs+release/8305/

PR-URL: #42285

Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: #42285

Refs: nodejs/node#42285 Signed-off-by: Stewart X Addison <sxa@redhat.com>

Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: nodejs#42285

sxa self-assigned this Mar 10, 2022

nodejs-github-bot added meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. v17.x labels Mar 10, 2022

sxa force-pushed the v17.7.1-proposal branch from 9f0da15 to 3486f40Compare March 10, 2022 15:27

slorber mentioned this pull request Mar 10, 2022
refactor(theme-classic): split sidebar into smaller parts facebook/docusaurus#6844
Merged

richardlau approved these changes Mar 10, 2022
View reviewed changes

cho-m mentioned this pull request Mar 10, 2022
node 17.7.1 Homebrew/homebrew-core#96599
Closed

Trott approved these changes Mar 10, 2022
View reviewed changes

Trott reviewed Mar 10, 2022
View reviewed changes

2022-03-10, Version 17.7.1 (Current)
8fe7979
Notable changes: Fixed regression in url.resolve() This release fixes an issue introduced in Node.js v17.7.0 with some URLs that contain `@`. This issue affected yarn 1. This version reverts the change that introduced the regression. PR-URL: #42285

sxa marked this pull request as ready for review March 10, 2022 17:50

sxa force-pushed the v17.7.1-proposal branch from 3486f40 to 8fe7979Compare March 10, 2022 17:50

BethGriggs approved these changes Mar 10, 2022
View reviewed changes

BethGriggs added a commit that referenced this pull request Mar 10, 2022
Working on v17.7.2
0694177
PR-URL: #42285

BethGriggs merged commit 8fe7979 into v17.xMar 10, 2022

sxa added a commit to sxa/nodejs.org that referenced this pull request Mar 10, 2022
Blog: v17.7.1 release post
766fbff
Refs: nodejs/node#42285 Signed-off-by: Stewart X Addison <sxa@redhat.com>

sxa mentioned this pull request Mar 10, 2022
Blog: v17.7.1 release post nodejs/nodejs.org#4479
Merged

BethGriggs pushed a commit to nodejs/nodejs.org that referenced this pull request Mar 10, 2022
Blog: v17.7.1 release post (#4479)
5c6de81
Refs: nodejs/node#42285 Signed-off-by: Stewart X Addison <sxa@redhat.com>

BethGriggs deleted the v17.7.1-proposal branch March 10, 2022 20:55

This was referenced Mar 11, 2022
CI Reliability 2022-03-11 nodejs/reliability#217
Open
CI Reliability 2022-03-12 nodejs/reliability#218
Open
CI Reliability 2022-03-13 nodejs/reliability#219
Open
CI Reliability 2022-03-14 nodejs/reliability#220
Open

BethGriggs mentioned this pull request Mar 15, 2022
Onboarding sxa as a releaser nodejs/Release#733
Open
6 tasks

Navigation Menu

Uh oh!

Uh oh!

v17.7.1 release proposal - #42285

v17.7.1 release proposal#42285
BethGriggs merged 2 commits into
v17.xfrom
v17.7.1-proposal

sxa commented Mar 10, 2022•
edited
Loading

Uh oh!

sxa commented Mar 10, 2022

Uh oh!

nodejs-github-bot commented Mar 10, 2022

Uh oh!

aduh95 commented Mar 10, 2022

Uh oh!

Trott commented Mar 10, 2022

Uh oh!

TrottMar 10, 2022•
edited
Loading

Uh oh!

bricss commented Mar 10, 2022

Uh oh!

sxa commented Mar 10, 2022

Uh oh!

sxa commented Mar 10, 2022

Uh oh!

BethGriggs commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

-This release fixes an issue introduced in Node.js v17.7.0 when the url
-has @ characters in it, which showed up when using yarn v1. This version
-reverts the change that introduced the regression.
+This release fixes an issue introduced in Node.js v17.7.0 with some URLs
+that contain `@`. This issue affected yarn v1. This version reverts the
+change that introduced the regression.

Uh oh!

Uh oh!

Conversation

sxa commented Mar 10, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2022-03-10, Version 17.7.1 (Current), @BethGriggs prepared by @sxa

Notable Changes

Fixed regression in url.resolve()

Commits

Uh oh!

sxa commented Mar 10, 2022

Uh oh!

nodejs-github-bot commented Mar 10, 2022

Uh oh!

aduh95 commented Mar 10, 2022

Uh oh!

Trott commented Mar 10, 2022

Uh oh!

TrottMar 10, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bricss commented Mar 10, 2022

Uh oh!

sxa commented Mar 10, 2022

Uh oh!

sxa commented Mar 10, 2022

Uh oh!

BethGriggs commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sxa commented Mar 10, 2022•
edited
Loading

TrottMar 10, 2022•
edited
Loading