Skip to content

test: improve code coverage for inspector connection errors - #42310

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
cola119:debugger-error-test-improve
May 25, 2022
Merged

test: improve code coverage for inspector connection errors#42310
aduh95 merged 1 commit into
nodejs:masterfrom
cola119:debugger-error-test-improve

Conversation

@cola119

@cola119cola119 commented Mar 12, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This PR added tests for error branches inconnectToMainThread. This is a small change but improves code coverage a bit.

Refs: lib/inspector.js.html#L74 and lib/inspector.js.html#L76

@cola119
cola119force-pushed the debugger-error-test-improve branch from 7fe0f4c to 6248cbcCompareMarch 12, 2022 14:21
@cola119cola119 changed the title debugger: improve code coverage for connection errorsinspector: improve code coverage for inspector connection errorsMar 12, 2022
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 12, 2022
@cola119
cola119 marked this pull request as ready for review March 12, 2022 14:30
@cola119cola119 changed the title inspector: improve code coverage for inspector connection errorstest: improve code coverage for inspector connection errorsMar 12, 2022
@cola119
cola119force-pushed the debugger-error-test-improve branch from 6248cbc to 31f19ccCompareMarch 12, 2022 16:26
@cola119
cola119force-pushed the debugger-error-test-improve branch from 31f19cc to ba42c4cCompareMarch 13, 2022 03:30
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Mar 14, 2022
Open
28 tasks
mhdawson
mhdawson approved these changes Mar 14, 2022
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot mentioned this pull request Mar 15, 2022
Open
20 tasks
@watildewatilde added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Mar 16, 2022
Open
Open
Open
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented May 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43955/

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2022
@watildewatilde added the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2022
@nodejs-github-bot

nodejs-github-bot commented May 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44083/

This was referenced May 20, 2022
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented May 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44115/

@nodejs-github-bot

nodejs-github-bot commented May 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44124/

This was referenced May 23, 2022
Open
Open
Open
@aduh95
aduh95 merged commit ee91acb into nodejs:masterMay 25, 2022
@aduh95

aduh95 commented May 25, 2022

Copy link
Copy Markdown
Contributor

Landed in ee91acb

@github-actionsgithub-actionsBot mentioned this pull request May 26, 2022
Open
19 tasks
bengl pushed a commit that referenced this pull request May 30, 2022
@cola119@bengl
test: improve code coverage for inspector connection errors
3e1ed1e
PR-URL: #42310
Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@benglbengl mentioned this pull request May 31, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@cola119@danielleadams
test: improve code coverage for inspector connection errors
3726310
PR-URL: #42310
Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@cola119@targos
test: improve code coverage for inspector connection errors
19da105
PR-URL: #42310
Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@cola119@targos
test: improve code coverage for inspector connection errors
fa70c99
PR-URL: #42310
Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@cola119@guangwong
test: improve code coverage for inspector connection errors
3d60325
PR-URL: nodejs/node#42310
Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cola119@nodejs-github-bot@aduh95@jasnell@lpinca@mhdawson@RaisinTen@watilde