Skip to content

test: add test for exception handlings in debugger - #42327

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
cola119:add-exception-test-cases
Apr 2, 2022
Merged

test: add test for exception handlings in debugger#42327
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
cola119:add-exception-test-cases

Conversation

@cola119

@cola119cola119 commented Mar 14, 2022

Copy link
Copy Markdown
Member

This PR added tests for error cases that might happen when the debugger backend server returns an invalid response.
This improves code coverage (here) from 89.01% to 90.7% in lib/internal/debugger/inspector_client.js.

beforeafter
imageimage
imageimage

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 14, 2022
aduh95
aduh95 reviewed Mar 14, 2022
View reviewed changes
Comment threadtest/parallel/test-debugger-invalid-json.js Outdated
Comment threadtest/parallel/test-debugger-invalid-json.js Outdated
Comment threadtest/parallel/test-debugger-invalid-json.js Outdated
Comment threadtest/parallel/test-debugger-invalid-json.js Outdated
Comment threadtest/parallel/test-debugger-invalid-json.js Outdated
Comment threadtest/parallel/test-debugger-invalid-json.js Outdated
@cola119
cola119 requested a review from aduh95March 14, 2022 12:40
@cola119
cola119force-pushed the add-exception-test-cases branch from 2854d44 to dca80cdCompareMarch 14, 2022 13:55
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 14, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43013/

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43023/

@github-actionsgithub-actionsBot mentioned this pull request Mar 15, 2022
Open
20 tasks
This was referenced Mar 16, 2022
Open
Open
Open
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit eda2498 into nodejs:masterApr 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in eda2498

juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@cola119@juanarbol
test: add test for exception handlings in debugger
f25ba8c
PR-URL: nodejs#42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@cola119@juanarbol
test: add test for exception handlings in debugger
797994e
PR-URL: #42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cola119
cola119 deleted the add-exception-test-cases branch April 8, 2022 15:37
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@cola119@xtx1130
test: add test for exception handlings in debugger
bb4c723
PR-URL: nodejs#42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@cola119@juanarbol
test: add test for exception handlings in debugger
846acac
PR-URL: #42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@cola119@danielleadams
test: add test for exception handlings in debugger
788953b
PR-URL: #42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@cola119@targos
test: add test for exception handlings in debugger
67a69d1
PR-URL: #42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@cola119@targos
test: add test for exception handlings in debugger
82d5e57
PR-URL: #42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@cola119@guangwong
test: add test for exception handlings in debugger
9fdcb64
PR-URL: nodejs/node#42327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@watildewatildewatilde approved these changes
@aduh95aduh95aduh95 approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cola119@nodejs-github-bot@jasnell@Trott@watilde@aduh95@trivikr