Skip to content

buffer: improve Blob constructor error message when passing a string - #42338

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
meixg:buffer-blob-err-meixg
Apr 4, 2022
Merged

buffer: improve Blob constructor error message when passing a string#42338
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
meixg:buffer-blob-err-meixg

Conversation

@meixg

@meixgmeixg commented Mar 15, 2022

Copy link
Copy Markdown
Member

resolve: #38856

newBlob('nodejs')

before:

TypeError [ERR_INVALID_ARG_TYPE]: The "sources" argument must be an instance of Iterable. Received type string ('nodejs')

after:

TypeError [ERR_INVALID_ARG_TYPE]: The "sources" argument must be a sequence. Received type string ('nodejs')

ref #38856 (comment):

error messages thrown by some browsers:
Chromium: TypeError: Failed to construct 'Blob': The provided value cannot be converted to a sequence.
Firefox: TypeError: Blob constructor: Argument 1 can't be converted to a sequence.
Safari: TypeError: Value is not a sequence

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 15, 2022
@aduh95
aduh95 requested a review from jasnellMarch 15, 2022 12:06
@meixgmeixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2022
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43082/

This was referenced Mar 18, 2022
Open
Open
Open
Open
@meixgmeixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43139/

@meixgmeixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43140/

@github-actionsgithub-actionsBot mentioned this pull request Mar 22, 2022
Open
32 tasks
@joyeecheungjoyeecheung mentioned this pull request Mar 22, 2022
Closed
This was referenced Mar 23, 2022
Open
Open
Open
jasnell
jasnell reviewed Mar 25, 2022
View reviewed changes
Comment threadlib/internal/blob.js
typeof sources[SymbolIterator] !== 'function' ||
typeof sources === 'string') {
throw new ERR_INVALID_ARG_TYPE('sources', 'Iterable', sources);
throw new ERR_INVALID_ARG_TYPE('sources', 'a sequence', sources);

@jasnelljasnellMar 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely better. might be worth indicating a sequence of what tho

This was referenced Mar 26, 2022
Open
Open
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2022
Open
11 tasks
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43320/

@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43323/

@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43325/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 46b633f into nodejs:masterApr 4, 2022
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

Landed in 46b633f

@github-actionsgithub-actionsBot mentioned this pull request Apr 5, 2022
Open
13 tasks
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@meixg@juanarbol
buffer: improve Blob constructor error message when passing a string
3fbfd65
resolve: nodejs#38856
PR-URL: nodejs#42338Fixes: nodejs#38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
@github-actionsgithub-actionsBot mentioned this pull request Apr 6, 2022
Open
11 tasks
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@meixg@juanarbol
buffer: improve Blob constructor error message when passing a string
7840a39
resolve: #38856
PR-URL: #42338Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@meixg@juanarbol
buffer: improve Blob constructor error message when passing a string
eb3dfc0
resolve: #38856
PR-URL: #42338Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@meixg@xtx1130
buffer: improve Blob constructor error message when passing a string
03c9532
resolve: nodejs#38856
PR-URL: nodejs#42338Fixes: nodejs#38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@meixg@juanarbol
buffer: improve Blob constructor error message when passing a string
e9f3e63
resolve: #38856
PR-URL: #42338Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@meixg@danielleadams
buffer: improve Blob constructor error message when passing a string
9532f5b
resolve: #38856
PR-URL: #42338Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@meixg@targos
buffer: improve Blob constructor error message when passing a string
2875684
resolve: #38856
PR-URL: #42338Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@meixg@targos
buffer: improve Blob constructor error message when passing a string
5ddd367
resolve: #38856
PR-URL: #42338Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@meixg@guangwong
buffer: improve Blob constructor error message when passing a string
9ec7e29
resolve: nodejs/node#38856
PR-URL: nodejs/node#42338Fixes: nodejs/node#38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blob constructor error message when passing a string is misleading

5 participants

@meixg@nodejs-github-bot@jasnell@benjamingr@aduh95