Skip to content

test: renew certificates for specific test - #42342

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:renew/certificates
Mar 15, 2022
Merged

test: renew certificates for specific test#42342
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:renew/certificates

Conversation

@lpinca

@lpincalpinca commented Mar 15, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Renew the certificates used by
test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js by
running the https_renew_cert.sh script under the same directory.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 15, 2022
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@lpinca
lpincaforce-pushed the renew/certificates branch from 29af814 to 24452d2CompareMarch 15, 2022 10:31
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@lpinca
lpincaforce-pushed the renew/certificates branch from 24452d2 to 9224069CompareMarch 15, 2022 10:37
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@lpinca
test: renew certificates for specific test
3b14f9a
Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.
@lpinca
lpincaforce-pushed the renew/certificates branch from 9224069 to 3b14f9aCompareMarch 15, 2022 10:41
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 15, 2022
@github-actions

github-actionsBot commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@tniessentniessen mentioned this pull request Mar 15, 2022
Merged
@tniessen

tniessen commented Mar 15, 2022

Copy link
Copy Markdown
Member

Consider #42343 so that we won't run into this problem every year, and for other minor improvements. We can also land this first and then I can rebase #42343 on top of this to reduce the diff.

@lpinca

lpinca commented Mar 15, 2022

Copy link
Copy Markdown
MemberAuthor

I also wanted to do that (improve the script) in a follow up PR.

@tniessen

tniessen commented Mar 15, 2022

Copy link
Copy Markdown
Member

Let's get this landed as soon as possible then.

@richardlau

richardlau commented Mar 15, 2022

Copy link
Copy Markdown
Member

@danielleadams FYI I suspect this will need to land on v16.x for tests to pass.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43050/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2022
@nodejs-github-bot
nodejs-github-bot merged commit d4d0b09 into nodejs:masterMar 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

Landed in d4d0b09

@lpinca
lpinca deleted the renew/certificates branch March 15, 2022 14:48
@richardlaurichardlau mentioned this pull request Mar 15, 2022
Merged
tniessen added a commit to tniessen/node that referenced this pull request Mar 15, 2022
@tniessen
test: improve https_renew_cert.sh script
1a2391d
- To avoid unnecessarily large diffs, only generate a new private key
if necessary. Otherwise, reuse the existing private key and only
issue a new certificate.
- Remove an unnecessary conversion step using openssl rsa and the
intermediate rsa.pem and csr.pem files.
- Extend the certificate validity from 1 year to 10 years.
- Show a text representation of the issued certificate upon completion
such that the user can verify the validity.
- Make the script executable.
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
- Allow the script to be called from any directory.
Refs: nodejs#42342
Refs: nodejs#37990
danielleadams pushed a commit that referenced this pull request Mar 15, 2022
@lpinca@danielleadams
test: renew certificates for specific test
ecb5263
Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.
PR-URL: #42342
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@github-actionsgithub-actionsBot mentioned this pull request Mar 16, 2022
Open
29 tasks
@mhdawsonmhdawson mentioned this pull request Mar 16, 2022
Closed
@github-actionsgithub-actionsBot mentioned this pull request Mar 17, 2022
Open
38 tasks
nodejs-github-bot pushed a commit that referenced this pull request Mar 17, 2022
@tniessen
test: improve https_renew_cert.sh script
adbc94c
- To avoid unnecessarily large diffs, only generate a new private key
if necessary. Otherwise, reuse the existing private key and only
issue a new certificate.
- Remove an unnecessary conversion step using openssl rsa and the
intermediate rsa.pem and csr.pem files.
- Extend the certificate validity from 1 year to 10 years.
- Show a text representation of the issued certificate upon completion
such that the user can verify the validity.
- Make the script executable.
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
- Allow the script to be called from any directory.
Refs: #42342
Refs: #37990
PR-URL: #42343
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 17, 2022
@lpinca@richardlau
test: renew certificates for specific test
457e31e
Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.
PR-URL: #42342
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@richardlaurichardlau mentioned this pull request Mar 17, 2022
Merged
This was referenced Mar 18, 2022
Open
Open
Open
Open
bengl pushed a commit that referenced this pull request Mar 21, 2022
@tniessen@bengl
test: improve https_renew_cert.sh script
b82bac0
- To avoid unnecessarily large diffs, only generate a new private key
if necessary. Otherwise, reuse the existing private key and only
issue a new certificate.
- Remove an unnecessary conversion step using openssl rsa and the
intermediate rsa.pem and csr.pem files.
- Extend the certificate validity from 1 year to 10 years.
- Show a text representation of the issued certificate upon completion
such that the user can verify the validity.
- Make the script executable.
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
- Allow the script to be called from any directory.
Refs: #42342
Refs: #37990
PR-URL: #42343
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Apr 21, 2022
@tniessen@danielleadams
test: improve https_renew_cert.sh script
36995cd
- To avoid unnecessarily large diffs, only generate a new private key
if necessary. Otherwise, reuse the existing private key and only
issue a new certificate.
- Remove an unnecessary conversion step using openssl rsa and the
intermediate rsa.pem and csr.pem files.
- Extend the certificate validity from 1 year to 10 years.
- Show a text representation of the issued certificate upon completion
such that the user can verify the validity.
- Make the script executable.
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
- Allow the script to be called from any directory.
Refs: nodejs#42342
Refs: nodejs#37990
PR-URL: nodejs#42343
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Apr 24, 2022
@tniessen@danielleadams
test: improve https_renew_cert.sh script
04243a8
- To avoid unnecessarily large diffs, only generate a new private key
if necessary. Otherwise, reuse the existing private key and only
issue a new certificate.
- Remove an unnecessary conversion step using openssl rsa and the
intermediate rsa.pem and csr.pem files.
- Extend the certificate validity from 1 year to 10 years.
- Show a text representation of the issued certificate upon completion
such that the user can verify the validity.
- Make the script executable.
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
- Allow the script to be called from any directory.
Refs: #42342
Refs: #37990
PR-URL: #42343
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@lpinca@xtx1130
test: renew certificates for specific test
b152356
Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.
PR-URL: nodejs#42342
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@tniessen@xtx1130
test: improve https_renew_cert.sh script
f86ec38
- To avoid unnecessarily large diffs, only generate a new private key
if necessary. Otherwise, reuse the existing private key and only
issue a new certificate.
- Remove an unnecessary conversion step using openssl rsa and the
intermediate rsa.pem and csr.pem files.
- Extend the certificate validity from 1 year to 10 years.
- Show a text representation of the issued certificate upon completion
such that the user can verify the validity.
- Make the script executable.
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash".
- Allow the script to be called from any directory.
Refs: nodejs#42342
Refs: nodejs#37990
PR-URL: nodejs#42343
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lpinca@nodejs-github-bot@tniessen@richardlau@joyeecheung@targos