Uh oh!
There was an error while loading. Please reload this page.
test: add test for extracting function name in inspect_repl.js - #42399
Merged
Conversation
cola119
commented
Mar 19, 2022
Comment on lines
+22
to
+23
| .then(() => cli.command('exec a = function func () {}; a;')) | ||
| .then(() => assert.match(cli.output, /\[Function\]/)) |
MemberAuthor
There was a problem hiding this comment.
The current logic seems to not consider white spaces between function name and brackets.
Trott
approved these changes
Mar 19, 2022
jasnell
approved these changes
Mar 25, 2022
This was referenced Mar 29, 2022
cola119
commented
Apr 30, 2022
MemberAuthor
nodejs-github-bot
commented
Apr 30, 2022
Collaborator
29 tasks
nodejs-github-bot
commented
May 1, 2022
Collaborator
nodejs-github-bot
commented
May 1, 2022
Collaborator
Landed in d268cf5 |
30 tasks
targos pushed a commit
that referenced
this pull request
May 2, 2022
PR-URL: #42399 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 3, 2022
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42399 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42399 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42399 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42399 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42399 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test for
extractFunctionNamefunction inlib/internal/debugger/inspect_repl.jsand improves code coverage. That function previously was untested. refI found some issues serializing a function name. I'll fix them in other PR.