Skip to content

docs: Fixing broken links to the v8 wiki - #4241

Closed
tomgco wants to merge 1 commit into
nodejs:masterfrom
tomgco:v8-wiki-links
Closed

docs: Fixing broken links to the v8 wiki#4241
tomgco wants to merge 1 commit into
nodejs:masterfrom
tomgco:v8-wiki-links

Conversation

@tomgco

Copy link
Copy Markdown
Contributor

The docs and _debugger.js are currently linking to the now non-existing v8 wiki on the v8 issue tracker; Instead it has now been moved to https://github.com/v8/v8/wiki

@evanlucas

Copy link
Copy Markdown
Contributor

LGTM

@mscdexmscdex added doc Issues and PRs related to the documentations. debugger v8 engine Issues and PRs related to the V8 dependency. labels Dec 11, 2015
@bnoordhuis

Copy link
Copy Markdown
Member

LGTM

@JungMinu

Copy link
Copy Markdown
Member

minor nit : docs -> doc

@JungMinuJungMinu self-assigned this Dec 11, 2015
@JungMinu

Copy link
Copy Markdown
Member

LGTM with one small comment :)

@tomgco

Copy link
Copy Markdown
ContributorAuthor

LGTM with one small comment :)

Thanks! Fixed up that.

jasnell pushed a commit that referenced this pull request Dec 11, 2015
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in 9a9c525

@jasnelljasnell closed this Dec 11, 2015
cjihrig pushed a commit that referenced this pull request Dec 15, 2015
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@rvaggrvagg mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4241
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@tomgco@evanlucas@bnoordhuis@JungMinu@jasnell@mscdex@MylesBorins