Uh oh!
There was an error while loading. Please reload this page.
tools: update eslint to 8.12.0 - #42489
Merged
Merged
Conversation
tniessen
approved these changes
Mar 27, 2022
trivikr
approved these changes
Mar 27, 2022
Trottforce-pushed
the
actions/tools-update-eslint
branch
from
March 27, 2022 03:49
684ea20 to
5bb9102CompareContributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
Trott
approved these changes
Mar 27, 2022
nodejs-github-bot
commented
Mar 27, 2022
CollaboratorAuthor
Mesteery
approved these changes
Mar 27, 2022
RaisinTen
approved these changes
Mar 27, 2022
aduh95
reviewed
Mar 27, 2022
| * cwd?: string; | ||
| * detached?: boolean; | ||
| * env?: Object; | ||
| * env?: object; |
Contributor
There was a problem hiding this comment.
The object type represents all non-primitive values in TS, should we use a more precise type? (Or maybe that’s JSDoc syntax and not TypeScript and object means something else?)
Suggested change
| *env?: object; | |
| *env?: Record<string,string>; |
Member
There was a problem hiding this comment.
Subsequent PR? This is just about getting our current entries to pass linting.
cjihrig
approved these changes
Mar 27, 2022
Trott
commented
Mar 27, 2022
Member
Landed in a7697c5...d143094 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Mar 27, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: nodejs#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trottforce-pushed
the
actions/tools-update-eslint
branch
from
March 27, 2022 15:36
5bb9102 to
d143094CompareTrott added a commit
to Trott/io.js
that referenced
this pull request
Mar 28, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs#42489 (comment)
nodejs-github-bot pushed a commit
that referenced
this pull request
Mar 30, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Apr 4, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Apr 4, 2022
PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Apr 4, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: nodejs#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs#42489 (comment) PR-URL: nodejs#42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Apr 6, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Apr 6, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
xtx1130 pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: nodejs#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
xtx1130 pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
xtx1130 pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs#42489 (comment) PR-URL: nodejs#42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: #42489 (comment) PR-URL: #42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Fix issue that will be flagged when we update ESLint and dependencies. PR-URL: nodejs/node#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42489 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Use JSDoc to indicate that the `env` object keys and values must be strings. Refs: nodejs/node#42489 (comment) PR-URL: nodejs/node#42494 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of eslint to 8.12.0.