Skip to content

doc: add introduction sentence for CJS - #42491

Merged
nodejs-github-bot merged 3 commits into
nodejs:masterfrom
aduh95:add-cjs-intro
Apr 2, 2022
Merged

doc: add introduction sentence for CJS#42491
nodejs-github-bot merged 3 commits into
nodejs:masterfrom
aduh95:add-cjs-intro

Conversation

@aduh95

@aduh95aduh95 commented Mar 27, 2022

Copy link
Copy Markdown
Contributor

Based on

node/doc/api/esm.md

Lines 62 to 64 in a01302b

ECMAScript modules are [the official standard format][] to package JavaScript
code for reuse. Modules are defined using a variety of [`import`][] and
[`export`][] statements.

It looks weird to me not to introduce what CJS is on its docs, and to call it the Node.js module system.

//cc @nodejs/modules

@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 27, 2022
@aduh95aduh95 mentioned this pull request Mar 27, 2022
Closed
ljharb
ljharb reviewed Mar 27, 2022
View reviewed changes
Comment threaddoc/api/modules.md Outdated
Comment threaddoc/api/modules.md Outdated
@ljharb

ljharb commented Mar 28, 2022

Copy link
Copy Markdown
Member

latest version looks great, thanks!

GeoffreyBooth
GeoffreyBooth reviewed Mar 28, 2022
View reviewed changes
Comment threaddoc/api/modules.md Outdated
Comment threaddoc/api/modules.md
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 30, 2022
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2dea9cc into nodejs:masterApr 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2dea9cc

juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@aduh95@juanarbol
doc: add introduction sentence for CJS
0c1e690
PR-URL: nodejs#42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@aduh95@juanarbol
doc: add introduction sentence for CJS
9449242
PR-URL: #42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@aduh95@xtx1130
doc: add introduction sentence for CJS
c40ab27
PR-URL: nodejs#42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@aduh95@juanarbol
doc: add introduction sentence for CJS
61ea408
PR-URL: #42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@aduh95@danielleadams
doc: add introduction sentence for CJS
ea588dd
PR-URL: #42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@aduh95@targos
doc: add introduction sentence for CJS
5688f8c
PR-URL: #42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95@targos
doc: add introduction sentence for CJS
73ce201
PR-URL: #42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95@guangwong
doc: add introduction sentence for CJS
a895838
PR-URL: nodejs/node#42491
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb left review comments
@TrottTrottTrott left review comments
@targostargostargos left review comments
@RaisinTenRaisinTenRaisinTen left review comments
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@marsonyamarsonyamarsonya approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@ljharb@GeoffreyBooth@Trott@targos@marsonya@RaisinTen