Uh oh!
There was an error while loading. Please reload this page.
test: fix typo in common/wpt.js - #42567
Merged
Merged
Conversation
thw -> the
himself65
approved these changes
Apr 1, 2022
cjihrig
approved these changes
Apr 1, 2022
VoltrexKeyva
approved these changes
Apr 1, 2022
marsonya
approved these changes
Apr 1, 2022
lpinca
approved these changes
Apr 1, 2022
Contributor
Fast-track has been requested by @marsonya. Please 👍 to approve. |
tniessen
approved these changes
Apr 1, 2022
nodejs-github-bot
commented
Apr 1, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42567 ✔ Done loading data for nodejs/node/pull/42567 ----------------------------------- PR info ------------------------------------ Title test: fix typo in common/wpt.js (#42567) Author Ikko Ashimine (@eltociear) Branch eltociear:patch-8 -> nodejs:master Labels test, fast-track, author ready Commits 1 - test: fix typo in common/wpt.js Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/42567 Reviewed-By: Zeyu Yang Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Akhil Marsonya Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42567 Reviewed-By: Zeyu Yang Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Akhil Marsonya Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 01 Apr 2022 14:03:18 GMT ✔ Approvals: 6 ✔ - Zeyu Yang (@himself65): https://github.com/nodejs/node/pull/42567#pullrequestreview-929000674 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929027796 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42567#pullrequestreview-929078664 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42567#pullrequestreview-929149813 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42567#pullrequestreview-929156607 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929305497 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2079678250 |
Trott
approved these changes
Apr 1, 2022
nodejs-github-bot
commented
Apr 2, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42567 ✔ Done loading data for nodejs/node/pull/42567 ----------------------------------- PR info ------------------------------------ Title test: fix typo in common/wpt.js (#42567) Author Ikko Ashimine (@eltociear) Branch eltociear:patch-8 -> nodejs:master Labels test, fast-track, author ready Commits 1 - test: fix typo in common/wpt.js Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/42567 Reviewed-By: Zeyu Yang Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Akhil Marsonya Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42567 Reviewed-By: Zeyu Yang Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Akhil Marsonya Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 01 Apr 2022 14:03:18 GMT ✔ Approvals: 7 ✔ - Zeyu Yang (@himself65): https://github.com/nodejs/node/pull/42567#pullrequestreview-929000674 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929027796 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42567#pullrequestreview-929078664 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42567#pullrequestreview-929149813 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42567#pullrequestreview-929156607 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929305497 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929491056 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2080321128 |
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Apr 2, 2022
Collaborator
nodejs-github-bot
commented
Apr 2, 2022
Collaborator
Landed in 127da0f |
This was referenced Apr 3, 2022
juanarbol pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
thw -> the PR-URL: nodejs#42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
11 tasks
juanarbol pushed a commit
that referenced
this pull request
Apr 6, 2022
thw -> the PR-URL: #42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
17 tasks
xtx1130 pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
thw -> the PR-URL: nodejs#42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
thw -> the PR-URL: #42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
thw -> the PR-URL: #42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2022
thw -> the PR-URL: #42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
thw -> the PR-URL: #42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
thw -> the PR-URL: nodejs/node#42567 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thw -> the