deps: update chromium zlib 1.2.12

[fabiomcarneiro]

Updates chromium zlib to 1.2.12
kept zlib.gyp build file.

https://chromium.googlesource.com/chromium/src/third_party/zlib/+/faff052b6b6edcd6dd548513fe44ac0941427bf0

[mscdex]

This change still needs to be backed out IIRC. Either that, or you might try adding defining CHROMIUM_ZLIB_NO_CHROMECONF in the gyp file to see if that works. I commented this out in my original PR that added the Chromium zlib implementation because it was breaking zlib tests.

[mscdex]

Unnecessary change

[Trott]

I'm OK with stripping out trailing spaces in this PR rather than leaving them or doing it in a separate PR.

[mscdex]

By the looks of it, the gyp will probably need to be updated to match the changes made to the build.gn file, especially for any optimization-related changes.

[targos]

Feel free to look at what I did in https://github.com/targos/node/tree/update-zlib-2 to fix the gyp config.

[Ilmarinen100]

am I correct to assume nodejs is vulnerable to CVE-2018-25032 until this is integrated/released?

[mscdex]

@Ilmarinen100#31201 (comment)

[LearnerOrLearnerr]

What would be the plan to close CVE-2018-25032 for the latest node LTS versions so that security scanning tools stop reporting the zlib implementation in node as vulnerable? I understand from the linked comments in #31201 that Chromium zlib which is being used is not vulnerable, but how to update nodejs such that this manual review of the situation and analysis is not required?

[Neustradamus]

Note there is now a 1.2.13 with CVE-2022-37434 fix.

[lpinca]

Superseded by #45387.