Skip to content

doc: remove obsolete stream API selection text - #42586

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:stream-pick
Apr 5, 2022
Merged

doc: remove obsolete stream API selection text#42586
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:stream-pick

Conversation

@Trott

@TrottTrott commented Apr 3, 2022

Copy link
Copy Markdown
Member

No description provided.

@Trott
Trott requested a review from benjamingrApril 3, 2022 05:49
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Apr 3, 2022
@benjamingr

benjamingr commented Apr 3, 2022

Copy link
Copy Markdown
Member

@nodejs/streams

mcollina
mcollina approved these changes Apr 3, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marsonyamarsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2022
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2022
@github-actions

github-actionsBot commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 5, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 08aab07 into nodejs:masterApr 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2022

Copy link
Copy Markdown
Collaborator

Landed in 08aab07

@Trott
Trott deleted the stream-pick branch April 5, 2022 12:19
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott@juanarbol
doc: remove obsolete stream API selection text
261672b
PR-URL: #42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@juanarboljuanarbol mentioned this pull request Apr 6, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott@xtx1130
doc: remove obsolete stream API selection text
efd5d24
PR-URL: nodejs#42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott@juanarbol
doc: remove obsolete stream API selection text
071d34a
PR-URL: #42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott@danielleadams
doc: remove obsolete stream API selection text
825193c
PR-URL: #42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott@targos
doc: remove obsolete stream API selection text
64399da
PR-URL: #42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott@targos
doc: remove obsolete stream API selection text
9129f02
PR-URL: #42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott@guangwong
doc: remove obsolete stream API selection text
5afc4e2
PR-URL: nodejs/node#42586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@ronagronagronag approved these changes
@marsonyamarsonyamarsonya approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@benjamingr@nodejs-github-bot@mcollina@jasnell@ronag@marsonya