Uh oh!
There was an error while loading. Please reload this page.
doc: mark tlsSocket.authorized as boolean property - #42647
Merged
nodejs-github-bot merged 1 commit intoApr 10, 2022
Merged
Conversation
Contributor
Fast-track has been requested by @tniessen. Please 👍 to approve. |
lpinca
approved these changes
Apr 8, 2022
aduh95
reviewed
Apr 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
This is not a function and should not have a return type.
tniessenforce-pushed
the
doc-tls-authorized-is-not-a-function
branch
from
April 9, 2022 21:43
0f9204c to
455358eCompareaduh95
approved these changes
Apr 9, 2022
nodejs-github-bot
commented
Apr 10, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42647 ✔ Done loading data for nodejs/node/pull/42647 ----------------------------------- PR info ------------------------------------ Title doc: mark tlsSocket.authorized as boolean property (#42647) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-tls-authorized-is-not-a-function -> nodejs:master Labels tls, doc, fast-track Commits 1 - doc: mark tlsSocket.authorized as boolean property Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42647 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42647 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 07 Apr 2022 23:50:39 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42647#pullrequestreview-935926911 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42647#pullrequestreview-937185969 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2142298995 |
nodejs-github-bot
commented
Apr 10, 2022
Collaborator
Landed in a046125 |
xtx1130 pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
This is not a function and should not have a return type. PR-URL: nodejs#42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
This is not a function and should not have a return type. PR-URL: #42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
This is not a function and should not have a return type. PR-URL: #42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 11, 2022
This is not a function and should not have a return type. PR-URL: #42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
This is not a function and should not have a return type. PR-URL: #42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This is not a function and should not have a return type. PR-URL: nodejs/node#42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a function and should not have a return type according to our documentation style guide.