Skip to content

doc: add maintaining-webassembly.md - #42660

Closed
mhdawson wants to merge 5 commits into
nodejs:masterfrom
mhdawson:maintaining-wasm
Closed

doc: add maintaining-webassembly.md#42660
mhdawson wants to merge 5 commits into
nodejs:masterfrom
mhdawson:maintaining-wasm

Conversation

@mhdawson

@mhdawsonmhdawson commented Apr 8, 2022

Copy link
Copy Markdown
Member

Add maintaining-webassembly.md with startegy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 8, 2022
VoltrexKeyva
VoltrexKeyva reviewed Apr 8, 2022
View reviewed changes
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
mhdawson
mhdawson commented Apr 8, 2022
View reviewed changes
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
marsonya
marsonya reviewed Apr 10, 2022
View reviewed changes
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
@tniessen

tniessen commented Apr 12, 2022•
edited
Loading

Copy link
Copy Markdown
Member

PR to add streaming compilation: #42701

Unfortunately, the spec only allows Response objects so far, but those can be backed by file streams.

@mhdawson

mhdawson commented Apr 12, 2022

Copy link
Copy Markdown
MemberAuthor

@tniessen thanks for the PR! Any chance you can review/approve this PR too?

tniessen
tniessen approved these changes Apr 12, 2022
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: there is a typo in the commit message ("strategy").

Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
@mhdawson
doc: add maintaining-webassembly.md
3d71723
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson

mhdawson commented Apr 13, 2022

Copy link
Copy Markdown
MemberAuthor

@tniessen thanks for the review, squashed and fixed the commit comment after pulling in your suggestions.

@mhdawson

mhdawson commented Apr 13, 2022

Copy link
Copy Markdown
MemberAuthor

@VoltrexMaster all of your comments should be fixed as well if you want to take another look.

VoltrexKeyva
VoltrexKeyva reviewed Apr 13, 2022
View reviewed changes
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
@mhdawson@VoltrexKeyva
Update doc/contributing/maintaining-web-assembly.md
eb76789
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
cjihrig
cjihrig approved these changes Apr 21, 2022
View reviewed changes
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated
mhdawsonand others added 3 commits April 21, 2022 16:10
@mhdawson@cjihrig
Update doc/contributing/maintaining-web-assembly.md
108f6cd
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@mhdawson@cjihrig
Update doc/contributing/maintaining-web-assembly.md
06263f8
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@mhdawson@cjihrig
Update doc/contributing/maintaining-web-assembly.md
a43f3a1
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@mhdawson

mhdawson commented Apr 21, 2022

Copy link
Copy Markdown
MemberAuthor

@cjihrig many thanks for reviewing.

@mhdawson

mhdawson commented Apr 21, 2022

Copy link
Copy Markdown
MemberAuthor

Checks passed and doc only so landing.

mhdawson added a commit that referenced this pull request Apr 21, 2022
@mhdawson
doc: add maintaining-webassembly.md
3a6b975
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mhdawson

mhdawson commented Apr 21, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in 3a6b975

tniessen added a commit to tniessen/node that referenced this pull request Apr 23, 2022
@tniessen
doc: update WebAssembly strategy with Wasm Web API
dfd8f0c
Refs: nodejs#42660
Refs: nodejs#42701
@tniessentniessen mentioned this pull request Apr 23, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@mhdawson@xtx1130
doc: add maintaining-webassembly.md
1fefafc
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 25, 2022
@tniessen
doc: update WebAssembly strategy with Wasm Web API
0f82afa
Refs: #42660
Refs: #42701
PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
@mhdawson@targos
doc: add maintaining-webassembly.md
59da133
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
@tniessen@targos
doc: update WebAssembly strategy with Wasm Web API
9b61ac2
Refs: #42660
Refs: #42701
PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@mhdawson@juanarbol
doc: add maintaining-webassembly.md
1b908ad
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen@juanarbol
doc: update WebAssembly strategy with Wasm Web API
6761023
Refs: #42660
Refs: #42701
PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@mhdawson@danielleadams
doc: add maintaining-webassembly.md
562b503
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen@danielleadams
doc: update WebAssembly strategy with Wasm Web API
5331e50
Refs: #42660
Refs: #42701
PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@mhdawson@targos
doc: add maintaining-webassembly.md
7b77887
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen@targos
doc: update WebAssembly strategy with Wasm Web API
9f2df9e
Refs: #42660
Refs: #42701
PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@mhdawson@targos
doc: add maintaining-webassembly.md
da97b86
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen@targos
doc: update WebAssembly strategy with Wasm Web API
9ab641e
Refs: #42660
Refs: #42701
PR-URL: #42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@mhdawson@guangwong
doc: add maintaining-webassembly.md
67e5c29
Add maintaining-webassembly.md with strategy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs/node#42660
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen@guangwong
doc: update WebAssembly strategy with Wasm Web API
b236d89
Refs: nodejs/node#42660
Refs: nodejs/node#42701
PR-URL: nodejs/node#42836
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsonyamarsonyamarsonya left review comments
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mhdawson@nodejs-github-bot@tniessen@cjihrig@marsonya@VoltrexKeyva