Skip to content

doc: improved parallel specification - #42679

Merged
nodejs-github-bot merged 4 commits into
nodejs:masterfrom
mawaregetsuka:doc
May 22, 2022
Merged

doc: improved parallel specification#42679
nodejs-github-bot merged 4 commits into
nodejs:masterfrom
mawaregetsuka:doc

Conversation

@mawaregetsuka

Copy link
Copy Markdown
Contributor

In current version description of parallel correlation are inconsistent with the Ninja official website, I therefore propose this improvement.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 10, 2022
Comment threaddoc/contributing/building-node-with-ninja.md Outdated
Comment threaddoc/contributing/building-node-with-ninja.md Outdated
mawaregetsukaand others added 2 commits April 10, 2022 22:36
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
@marsonya
marsonya requested a review from mscdexApril 10, 2022 18:40
@mawaregetsuka

Copy link
Copy Markdown
ContributorAuthor

Let's push this PR to the next phase. @mscdex

Comment threaddoc/contributing/building-node-with-ninja.md Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 22, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 40162db into nodejs:masterMay 22, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 40162db

bengl pushed a commit that referenced this pull request May 30, 2022
PR-URL: #42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@benglbengl mentioned this pull request May 31, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mawaregetsuka@nodejs-github-bot@mscdex@lpinca@aduh95