Uh oh!
There was an error while loading. Please reload this page.
[v16.x backport] esm: add HTTPS imports and unflag JSON modules - #42726
Closed
aduh95 wants to merge 2 commits into
Closed
[v16.x backport] esm: add HTTPS imports and unflag JSON modules#42726aduh95 wants to merge 2 commits into
aduh95 wants to merge 2 commits into
Conversation
PR-URL: nodejs#41736 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: James Sumners <james@sumners.email> PR-URL: nodejs#36328 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
nodejs-github-bot
commented
Apr 13, 2022
Collaborator
Review requested:
|
danielleadams
commented
Apr 14, 2022
Contributor
thank you! 🎉 |
danielleadams
approved these changes
Apr 14, 2022
This was referenced Apr 14, 2022
nodejs-github-bot
commented
Apr 14, 2022
Collaborator
aduh95
commented
Apr 14, 2022
ContributorAuthor
FWIW I just tried to cherry-pick the two PRs you linked and I can confirm it lands cleanly on this PR branch. I should probably have included them to save you some work, sorry I didn't take the time to search for follow-up PRs. |
GeoffreyBooth
approved these changes
Apr 14, 2022
danielleadams
commented
Apr 18, 2022
Contributor
ljharb
reviewed
Apr 18, 2022
| <!-- YAML | ||
| added: v12.9.0 | ||
| added: v9.0.0 |
Member
There was a problem hiding this comment.
are we sure this was added in node 9?
Running node v9.11.2 (npm v5.6.0)
node: bad option: --experimental-loader=moduleContributorAuthor
There was a problem hiding this comment.
Don't know, could be wrong, this info is from #22104 and not related to this backport.
danielleadams
commented
Apr 20, 2022
Contributor
Landed in f8819e8...0d185f7 |
danielleadams pushed a commit
that referenced
this pull request
Apr 20, 2022
PR-URL: #41736 Backport-PR-URL: #42726 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Apr 20, 2022
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: James Sumners <james@sumners.email> PR-URL: #36328 Backport-PR-URL: #42726 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41736 and #36328
/cc @danielleadams