Skip to content

doc: copyedit http.OutgoingMessage documentation - #42733

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:copyedit/outgoing-message-documentation
Apr 17, 2022
Merged

doc: copyedit http.OutgoingMessage documentation#42733
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:copyedit/outgoing-message-documentation

Conversation

@lpinca

Copy link
Copy Markdown
Member

Fix nits/typos and simplify some sentences.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 14, 2022
@lpinca
lpincaforce-pushed the copyedit/outgoing-message-documentation branch 2 times, most recently from 460a5b0 to 2aa311eCompareApril 14, 2022 10:34
Comment threaddoc/api/http.md Outdated
Comment on lines 2804 to 2807

@lpincalpincaApr 14, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified this because a detailed and specific description exists for both ClientRequest#write() and ServerResponse#write().

Fix nits/typos and simplify some sentences.
@lpinca
lpincaforce-pushed the copyedit/outgoing-message-documentation branch from 2aa311e to f2785c1CompareApril 14, 2022 10:44

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good job!

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 0699150 into nodejs:masterApr 17, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 0699150

@lpinca
lpinca deleted the copyedit/outgoing-message-documentation branch April 17, 2022 19:24
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Fix nits/typos and simplify some sentences.
PR-URL: nodejs#42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
Fix nits/typos and simplify some sentences.
PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targostargos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
Fix nits/typos and simplify some sentences.
PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Fix nits/typos and simplify some sentences.
PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
Fix nits/typos and simplify some sentences.
PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Fix nits/typos and simplify some sentences.
PR-URL: #42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Fix nits/typos and simplify some sentences.
PR-URL: nodejs/node#42733
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lpinca@nodejs-github-bot@mcollina@ShogunPanda