deps: upgrade libuv to 1.8.0 by saghul · Pull Request #4276 · nodejs/node

saghul · 2015-12-14T20:12:43Z

R=@bnoordhuis

/cc @nodejs/collaborators

@rvagg items for release notes:

AIX improvements

saghul · 2015-12-14T20:14:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/995/

cjihrig · 2015-12-14T20:16:04Z

Rubber stamp LGTM if the CI is happy.

seishun · 2015-12-14T20:19:43Z

Merging this should fix #3718.

jasnell · 2015-12-14T20:29:51Z

LGTM if CI is green

saghul · 2015-12-14T20:33:50Z

@seishun good catch, thanks.

saghul · 2015-12-14T20:35:35Z

Is this the new way of Jenkins telling me the build is green? https://ci.nodejs.org/job/node-test-commit/1431/

cjihrig · 2015-12-14T20:45:15Z

@saghul yes, it looks like the only failures are known flakey tests on Windows.

saghul · 2015-12-14T20:50:53Z

Oh, forgot to mention, we now have uv_fs_realpath.

Fixes: nodejs#3718 PR-URL: nodejs#4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

saghul · 2015-12-14T20:55:29Z

Merged, thanks for the reviews! ❤️

Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: #4281

Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) #3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: #4281

Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) #3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: #4281 Conflicts: src/node_version.h

evanlucas · 2015-12-29T17:47:12Z

@jasnell can this be backported to LTS? It fixes a segfault on OS X (#4091)

rvagg · 2015-12-30T13:03:52Z

Worth pulling in @nodejs/lts on this one, do we need to think on our policy re libuv & LTS or is case-by-case OK? It seems for this particular upgrade we get some AIX improvements and the fix for #4091 — please consider that issue, I can't work out whether it should be considered a rare edge-case or something that will come up now and again for Argon users.

saghul · 2015-12-30T14:01:41Z

FWIW, libuv v1.x keeps a strict backwards API compatibility and ABI stability, so pulling in every v1.x release into LTS should never result in breakage.

jasnell · 2015-12-30T14:21:01Z

So long as there is no ABI breakage I've got no problem with that.
On Dec 30, 2015 5:04 AM, "Rod Vagg" notifications@github.com wrote:

Worth pulling in @nodejs/lts https://github.com/orgs/nodejs/teams/lts
on this one, do we need to think on our policy re libuv & LTS or is
case-by-case OK? It seems for this particular upgrade we get some AIX
improvements and the fix for #4091
#4091 — please consider that
issue, I can't work out whether it should be considered a rare edge-case or
something that will come up now and again for Argon users.
—
Reply to this email directly or view it on GitHub
#4276 (comment).

Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2016-01-07T00:01:22Z

I've landed this onto v4.x-staging.

Here is a CI run to be safe --> https://ci.nodejs.org/job/node-test-commit/1636/

Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fixes: nodejs#3718 PR-URL: nodejs#4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) nodejs#3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) nodejs#3654. * https: - Added support for disabling session caching. (Fedor Indutny) nodejs#4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) nodejs#4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) nodejs#4276. PR-URL: nodejs#4281 Conflicts: src/node_version.h

saghul added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Dec 14, 2015

silverwind added the relnotes label Dec 14, 2015

saghul force-pushed the uv-upgrade branch from 18c5e36 to 952c17eCompare December 14, 2015 20:53

deps: upgrade libuv to 1.8.0
69b94ec
Fixes: nodejs#3718 PR-URL: nodejs#4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

saghul force-pushed the uv-upgrade branch from 952c17e to 69b94ecCompare December 14, 2015 20:53

saghul closed this Dec 14, 2015

saghul deleted the uv-upgrade branch December 14, 2015 20:55

saghul merged commit 69b94ec into nodejs:masterDec 14, 2015

Fishrock123 mentioned this pull request Dec 15, 2015
v5.3.0 Release Proposal (Stable) #4281
Closed

saghul added a commit that referenced this pull request Dec 15, 2015
deps: upgrade libuv to 1.8.0
2cfc407
Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

rvagg mentioned this pull request Dec 17, 2015
Release 4.2.4 Planning #4321
Closed

MylesBorins added the lts-watch-v4.x label Dec 29, 2015

saghul added a commit that referenced this pull request Jan 6, 2016
deps: upgrade libuv to 1.8.0
c23dea8
Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jan 6, 2016

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
deps: upgrade libuv to 1.8.0
1ebb0c0
Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins mentioned this pull request Jan 19, 2016
V4.2.5 proposal #4768
Merged

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
deps: upgrade libuv to 1.8.0
05ad666
Fixes: nodejs#3718 PR-URL: nodejs#4276 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Uh oh!

Uh oh!

Conversation

saghul commented Dec 14, 2015

Uh oh!

saghul commented Dec 14, 2015

Uh oh!

cjihrig commented Dec 14, 2015

Uh oh!

seishun commented Dec 14, 2015

Uh oh!

jasnell commented Dec 14, 2015

Uh oh!

saghul commented Dec 14, 2015

Uh oh!

saghul commented Dec 14, 2015

Uh oh!

cjihrig commented Dec 14, 2015

Uh oh!

saghul commented Dec 14, 2015

Uh oh!

saghul commented Dec 14, 2015

Uh oh!

evanlucas commented Dec 29, 2015

Uh oh!

rvagg commented Dec 30, 2015

Uh oh!

saghul commented Dec 30, 2015

Uh oh!

jasnell commented Dec 30, 2015

Uh oh!

MylesBorins commented Jan 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants