debugger: fix TypeError of list command in inspector repl by cola119 · Pull Request #42776 · nodejs/node

cola119 · 2022-04-18T14:28:56Z

Currently list command throws TypeError after the inspector is disconnected.
This PR fixed to throw ERR_DEBUGGER_ERROR instead of TypeError.

Fixes: #42775

meixg · 2022-04-20T02:46:20Z

There is a ci failure that seems related to the change : https://github.com/nodejs/node/runs/6070093179?check_suite_focus=true

cola119 · 2022-04-20T05:46:54Z

@meixg Thank you. I fixed. (but test/parallel/test-cluster-primary-kill.js failed 🥲

nodejs-github-bot · 2022-04-20T06:12:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43581/

aduh95 · 2022-04-20T09:50:19Z

Based on the CI failures, it looks like this is quite flaky on some configurations 🤔 Any idea what might be causing this?

cola119 · 2022-04-20T21:27:18Z

@aduh95 It seems to be fixed by 2206bd0fb908491a21ae16f5db4beeee72a038bb

jasnell · 2022-04-20T21:51:45Z

Can this be refactored into an async function with awaits rather than a long then chain?

@jasnell done fea46820e4dc50e74340bc58e10c898bebfe7ed2

nodejs-github-bot · 2022-04-21T09:54:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43610/

nodejs-github-bot · 2022-04-21T15:54:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43621/

aduh95 · 2022-04-21T21:39:10Z

There seems to be some related CI failures

node:internal/process/promises:288
triggerUncaughtException(err, true /* fromPromise */);
^
AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Uncaught Error \[ERR_DEBUGGER_ERROR\]: Requires execution to be paused/. Input:
'debug> '
at /home/iojs/build/workspace/node-test-commit-linux/test/sequential/test-debugger-list.js:26:10
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: 'debug> ',
expected: /Uncaught Error \[ERR_DEBUGGER_ERROR\]: Requires execution to be paused/,
operator: 'match'
}
Node.js v19.0.0-pre

nodejs-github-bot · 2022-04-22T10:13:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43633/

nodejs-github-bot · 2022-05-22T10:26:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44116/

nodejs-github-bot · 2022-05-22T11:34:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44122/

aduh95 · 2022-05-22T13:09:29Z

Landed in cbb92b0

PR-URL: #42776Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams · 2022-06-27T15:00:07Z

@cola119 This breaks the test suite when trying to land in v16.x. Do you mind opening up a backport PR to v16.x-staging? (docs) Thank you.

PR-URL: nodejs#42776Fixes: nodejs#42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #42776Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#42776Fixes: nodejs/node#42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Apr 18, 2022

aduh95 reviewed Apr 18, 2022
View reviewed changes

Comment threadtest/sequential/test-debugger-list.js Outdated

cola119 requested a review from aduh95 April 20, 2022 01:46

cola119 force-pushed the fix-cannot-read-props-of-null-error branch from ae6defd to cd64887Compare April 20, 2022 03:16

meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2022

aduh95 approved these changes Apr 20, 2022
View reviewed changes

jasnell reviewed Apr 20, 2022
View reviewed changes

github-actionsBot mentioned this pull request Apr 21, 2022
CI Reliability 2022-04-21 nodejs/reliability#258
Open
22 tasks

cola119 requested a review from jasnell April 21, 2022 02:58

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2022

github-actionsBot mentioned this pull request Apr 22, 2022
CI Reliability 2022-04-22 nodejs/reliability#259
Open
19 tasks

cola119 added 3 commits April 22, 2022 12:58

debugger: throw debugger error when the frame is missing
e45af10

test: fix flaky test
832435f

test: refactor into async-await
88f48e0

cola119 force-pushed the fix-cannot-read-props-of-null-error branch from fea4682 to 88f48e0Compare April 22, 2022 03:59

test: fix flaky test
4cbbd47

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2022

This was referenced May 20, 2022
CI Reliability 2022-05-20 nodejs/reliability#283
Open
CI Reliability 2022-05-21 nodejs/reliability#284
Open
CI Reliability 2022-05-22 nodejs/reliability#285
Open

aduh95 merged commit cbb92b0 into nodejs:masterMay 22, 2022

bengl pushed a commit that referenced this pull request May 30, 2022
debugger: throw a more useful error when the frame is missing
c76caad
PR-URL: #42776Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bengl mentioned this pull request May 31, 2022
v18.3.0 proposal #43266
Merged

juanarbol pushed a commit that referenced this pull request May 31, 2022
debugger: throw a more useful error when the frame is missing
1702a80
PR-URL: #42776Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

juanarbol mentioned this pull request May 31, 2022
2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268
Closed

danielleadams added the backport-requested-v16.x label Jun 27, 2022

cola119 mentioned this pull request Jun 27, 2022
[v16.x backport] debugger: throw a more useful error when the frame is missing #43595
Closed

targos pushed a commit that referenced this pull request Jul 18, 2022
debugger: throw a more useful error when the frame is missing
98a5670
PR-URL: #42776Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

targos removed the backport-requested-v16.x label Jul 18, 2022

targos pushed a commit that referenced this pull request Jul 31, 2022
debugger: throw a more useful error when the frame is missing
f1c12aa
PR-URL: #42776Fixes: #42775 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged

Uh oh!

Uh oh!

Conversation

cola119 commented Apr 18, 2022• edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

meixg commented Apr 20, 2022

Uh oh!

cola119 commented Apr 20, 2022

Uh oh!

nodejs-github-bot commented Apr 20, 2022

Uh oh!

aduh95 commented Apr 20, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cola119 commented Apr 20, 2022

Uh oh!

jasnellApr 20, 2022

Choose a reason for hiding this comment

Uh oh!

cola119Apr 21, 2022

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 21, 2022

Uh oh!

nodejs-github-bot commented Apr 21, 2022

Uh oh!

aduh95 commented Apr 21, 2022

Uh oh!

nodejs-github-bot commented Apr 22, 2022

Uh oh!

nodejs-github-bot commented May 22, 2022

Uh oh!

nodejs-github-bot commented May 22, 2022

Uh oh!

aduh95 commented May 22, 2022

Uh oh!

danielleadams commented Jun 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cola119 commented Apr 18, 2022•
edited by aduh95
Loading

aduh95 commented Apr 20, 2022•
edited
Loading