Skip to content

[v16.x backport] test: improve code coverage for streams/duplexify - #42788

Closed
ErickWendel wants to merge 1 commit into
nodejs:v16.x-stagingfrom
ErickWendel:erick/backport-streams-improve-code-coverage
Closed

[v16.x backport] test: improve code coverage for streams/duplexify#42788
ErickWendel wants to merge 1 commit into
nodejs:v16.x-stagingfrom
ErickWendel:erick/backport-streams-improve-code-coverage

Conversation

@ErickWendel

@ErickWendelErickWendel commented Apr 19, 2022

Copy link
Copy Markdown
Member

Backport of #41862

/cc @danielleadams

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 19, 2022
@danielleadamsdanielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 20, 2022
@github-actions

github-actionsBot commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43591/

@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43599/

@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43603/

This was referenced Apr 21, 2022
Open
Open
Open
@ErickWendel
ErickWendel changed the base branch from master to v16.x-stagingApril 23, 2022 15:18
@ErickWendel
ErickWendel changed the base branch from v16.x-staging to masterApril 23, 2022 15:18
This was referenced Apr 24, 2022
Open
Open
Open
@ErickWendel

ErickWendel commented May 24, 2022

Copy link
Copy Markdown
MemberAuthor

is anything missing to approve on this PR?

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced May 30, 2022
Open
Open
@nodejs-github-bot

nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44253/

This was referenced Jun 1, 2022
Open
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44809/

@danielleadams

danielleadams commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

@nodejs/collaborators would anyone else be able to review this?

mcollina
mcollina approved these changes Jun 23, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44819/

@danielleadams

danielleadams commented Jun 26, 2022

Copy link
Copy Markdown
Contributor

@ErickWendel I just realized the base of this PR is pointed to main. Can you point it to v16.x-staging and then resolve the merge conflicts? Thank you!

@ErickWendel

ErickWendel commented Jun 27, 2022

Copy link
Copy Markdown
MemberAuthor

@ErickWendel I just realized the base of this PR is pointed to main. Can you point it to v16.x-staging and then resolve the merge conflicts? Thank you!

Oh. I'm sorry about it. I'll do. This week is being crazy here but I'll trying doing it by the weekend

@ErickWendel

ErickWendel commented Jul 4, 2022

Copy link
Copy Markdown
MemberAuthor

hey just a heads up. I'm back from vacations so I'll be working on this feature this week o/

@ErickWendel
ErickWendelforce-pushed the erick/backport-streams-improve-code-coverage branch from 7fd01a6 to 9bd0c30CompareJuly 5, 2022 20:12
@ErickWendel
ErickWendel changed the base branch from main to v16.x-stagingJuly 5, 2022 20:12
@ErickWendel
ErickWendel deleted the erick/backport-streams-improve-code-coverage branch July 5, 2022 20:15
@ErickWendel
ErickWendel restored the erick/backport-streams-improve-code-coverage branch July 5, 2022 20:15
@ErickWendelErickWendel reopened this Jul 5, 2022
@ErickWendel
ErickWendelforce-pushed the erick/backport-streams-improve-code-coverage branch from 9bd0c30 to 5bedc83CompareJuly 5, 2022 20:25
@ErickWendel

ErickWendel commented Jul 6, 2022

Copy link
Copy Markdown
MemberAuthor

Ready to go now 🤩

@Trott
Trottforce-pushed the erick/backport-streams-improve-code-coverage branch from 5bedc83 to e8d4384CompareJuly 8, 2022 15:59
@targos

targos commented Jul 12, 2022

Copy link
Copy Markdown
Member

Thank you @ErickWendel. Landed in 4aa4f7c

@targostargos closed this Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
@ErickWendel@targos
test: improve code coverage for streams/duplexify
4aa4f7c
PR-URL: #41862
Backport-PR-URL: #42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@ErickWendel@targos
test: improve code coverage for streams/duplexify
147f99c
PR-URL: #41862
Backport-PR-URL: #42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@ErickWendel@guangwong
test: improve code coverage for streams/duplexify
aae131c
PR-URL: nodejs/node#41862
Backport-PR-URL: nodejs/node#42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@cclausscclausscclauss approved these changes
@himself65himself65himself65 approved these changes
@benjamingrbenjamingrAwaiting requested review from benjamingr
@cjihrigcjihrigAwaiting requested review from cjihrig
@juanarboljuanarbolAwaiting requested review from juanarbol
+1 more reviewer
@danielleadamsdanielleadamsdanielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ErickWendel@nodejs-github-bot@danielleadams@targos@mcollina@cclauss@himself65@juanarbol