doc: amend support tier qualifier by gireeshpunathil · Pull Request #42805 · nodejs/node

gireeshpunathil · 2022-04-21T04:46:33Z

Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: #42802

nodejs-github-bot · 2022-04-21T04:46:37Z

Review requested:

@nodejs/tsc

RafaelGSS

LGTM.

gireeshpunathil · 2023-03-11T15:14:34Z

this can have more reviews.

mcollina

lgtm

nodejs-github-bot · 2023-03-12T12:39:37Z

Commit Queue failed

- Loading data for nodejs/node/pull/42805 ✔ Done loading data for nodejs/node/pull/42805 ----------------------------------- PR info ------------------------------------ Title doc: amend support tier qualifier (#42805) Author Gireesh Punathil (@gireeshpunathil) Branch gireeshpunathil:support-tiers-tier3-define -> nodejs:main Labels doc Commits 2 - doc: amend support tier qualifier - fixup: reword based on review comments Committers 1 - Gireesh Punathil PR-URL: https://github.com/nodejs/node/pull/42805 Refs: https://github.com/nodejs/node/pull/42802 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42805 Refs: https://github.com/nodejs/node/pull/42802 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 Apr 2022 04:46:33 GMT ✔ Approvals: 3 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-948787072 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336000383 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336014453 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 42805 From https://github.com/nodejs/node * branch refs/pull/42805/merge -> FETCH_HEAD ✔ Fetched commits as 7f2ab4e62985..e4da26ed9005 -------------------------------------------------------------------------------- [main 7e2d9f14fd] doc: amend support tier qualifier Author: Gireesh Punathil Date: Thu Apr 21 10:11:32 2022 +0530 1 file changed, 4 insertions(+), 3 deletions(-) [main 6ffb3148ac] fixup: reword based on review comments Author: Gireesh Punathil Date: Sat Mar 11 19:01:42 2023 +0530 1 file changed, 3 insertions(+), 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: #42802, skipping..
--------------------------------- New Message ----------------------------------
doc: amend support tier qualifier

Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: #42802
PR-URL: #42805
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD 8376941e12] doc: amend support tier qualifier
Author: Gireesh Punathil gpunathi@in.ibm.com
Date: Thu Apr 21 10:11:32 2022 +0530
1 file changed, 4 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup: reword based on review comments

PR-URL: #42805
Refs: #42802
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

[detached HEAD 1952bf7a4c] fixup: reword based on review comments
Author: Gireesh Punathil gpunathi@in.ibm.com
Date: Sat Mar 11 19:01:42 2023 +0530
1 file changed, 3 insertions(+), 4 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4397476877

Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: nodejs#42802

nodejs-github-bot · 2023-03-12T16:31:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/42805
✔ Done loading data for nodejs/node/pull/42805
----------------------------------- PR info ------------------------------------
Title doc: amend support tier qualifier (#42805)
Author Gireesh Punathil (@gireeshpunathil)
Branch gireeshpunathil:support-tiers-tier3-define -> nodejs:main
Labels doc
Commits 1
- doc: amend support tier qualifier
Committers 1
- Gireesh Punathil PR-URL: https://github.com/nodejs/node/pull/42805
Refs: https://github.com/nodejs/node/pull/42802
Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42805
Refs: https://github.com/nodejs/node/pull/42802
Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - doc: amend support tier qualifier
ℹ This PR was created on Thu, 21 Apr 2022 04:46:33 GMT
✔ Approvals: 3
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-948787072
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336000383
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336014453
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4398393764

Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

gireeshpunathil · 2023-03-13T02:55:08Z

landed in 59dd9ca

Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 21, 2022

RafaelGSS approved these changes Apr 21, 2022
View reviewed changes

mhdawson reviewed Apr 21, 2022
View reviewed changes

Comment threaddoc/contributing/diagnostic-tooling-support-tiers.md Outdated

RaisinTen reviewed Apr 22, 2022
View reviewed changes

Comment threaddoc/contributing/diagnostic-tooling-support-tiers.md Outdated

Trott force-pushed the main branch from 2d76238 to ca3ed36Compare November 12, 2022 01:49

gireeshpunathil force-pushed the support-tiers-tier3-define branch from 3ff7a3e to e4da26eCompare March 11, 2023 13:33

mcollina approved these changes Mar 12, 2023
View reviewed changes

RaisinTen approved these changes Mar 12, 2023
View reviewed changes

gireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 12, 2023

gireeshpunathil added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 12, 2023

doc: amend support tier qualifier
d5b971f
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: nodejs#42802

gireeshpunathil force-pushed the support-tiers-tier3-define branch from e4da26e to d5b971fCompare March 12, 2023 14:30

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 12, 2023

cjihrig approved these changes Mar 13, 2023
View reviewed changes

gireeshpunathil closed this Mar 13, 2023

targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged

danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged

Navigation Menu

Uh oh!

Uh oh!

doc: amend support tier qualifier - #42805

doc: amend support tier qualifier#42805
gireeshpunathil wants to merge 1 commit into
nodejs:mainfrom
gireeshpunathil:support-tiers-tier3-define

gireeshpunathil commented Apr 21, 2022

Uh oh!

nodejs-github-bot commented Apr 21, 2022

Uh oh!

RafaelGSS left a comment

Uh oh!

Uh oh!

Uh oh!

gireeshpunathil commented Mar 11, 2023

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Refs: #42802
PR-URL: #42805
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #42805
Refs: #42802
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

gireeshpunathil commented Mar 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

gireeshpunathil commented Apr 21, 2022

Uh oh!

nodejs-github-bot commented Apr 21, 2022

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gireeshpunathil commented Mar 11, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Refs: #42802 PR-URL: #42805 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #42805 Refs: #42802 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Darshan Sen raisinten@gmail.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

gireeshpunathil commented Mar 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Refs: #42802
PR-URL: #42805
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com

PR-URL: #42805
Refs: #42802
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com