Skip to content

errors,vm: update error and use cause - #42820

Merged
devsnek merged 1 commit into
masterfrom
module-link-error-cause
Apr 24, 2022
Merged

errors,vm: update error and use cause#42820
devsnek merged 1 commit into
masterfrom
module-link-error-cause

Conversation

@devsnek

@devsnekdevsnek commented Apr 22, 2022

Copy link
Copy Markdown
Member

Resolve an ancient todo that I forgot about. This provides an error that matches other link errors and also uses the cause property to provide more context.

@nodejs-github-botnodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43630/

aduh95
aduh95 approved these changes Apr 22, 2022
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not semver-major because vm.Module is still experimental and behind a flag, correct?

@aduh95aduh95 added experimental Issues and PRs related to experimental features. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 22, 2022
This was referenced Apr 23, 2022
Open
Open
@devsnek
errors,vm: update error and use cause
7729e32
PR-URL: #42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@devsnek
devsnekforce-pushed the module-link-error-cause branch from c9b94d4 to 7729e32CompareApril 24, 2022 15:34
@devsnek
devsnek merged commit 7729e32 into masterApr 24, 2022
@devsnek
devsnek deleted the module-link-error-cause branch April 24, 2022 15:34
@github-actionsgithub-actionsBot mentioned this pull request Apr 25, 2022
Open
16 tasks
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@devsnek@xtx1130
errors,vm: update error and use cause
f203139
PR-URL: nodejs#42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This was referenced Apr 26, 2022
Open
Open
targos pushed a commit that referenced this pull request Apr 28, 2022
@devsnek@targos
errors,vm: update error and use cause
0e16120
PR-URL: #42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targostargos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@devsnek@juanarbol
errors,vm: update error and use cause
9e815c5
PR-URL: #42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@devsnek@danielleadams
errors,vm: update error and use cause
5f9343d
PR-URL: #42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@devsnek@targos
errors,vm: update error and use cause
e100889
PR-URL: #42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@devsnek@targos
errors,vm: update error and use cause
85ba4e0
PR-URL: #42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@devsnek@guangwong
errors,vm: update error and use cause
70d6bbc
PR-URL: nodejs/node#42820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.errorsIssues and PRs related to JavaScript errors originated in Node.js core.experimentalIssues and PRs related to experimental features.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devsnek@nodejs-github-bot@jasnell@aduh95@RaisinTen@VoltrexKeyva