Skip to content

doc: rename N-API to Node-API in test/README.md - #42946

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
daeyeon:master.doc-220503.Tue.c858
May 9, 2022
Merged

doc: rename N-API to Node-API in test/README.md#42946
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
daeyeon:master.doc-220503.Tue.c858

Conversation

@daeyeon

Copy link
Copy Markdown
Member

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 2, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
@daeyeon
daeyeonforce-pushed the master.doc-220503.Tue.c858 branch from a985cc1 to f40576fCompareMay 2, 2022 16:09

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessentniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 8, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 0950da1 into nodejs:masterMay 9, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 0950da1

@daeyeon
daeyeon deleted the master.doc-220503.Tue.c858 branch May 9, 2022 13:23
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #42946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 10, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #42946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #42946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #42946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #42946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: nodejs/node#42946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@daeyeon@nodejs-github-bot@lpinca@tniessen@mhdawson@marsonya@RaisinTen@HarshithaKP@richardlau