Skip to content

test-crypto-fips.js fails with shared OpenSSL 3 - #42947

Closed
batrla wants to merge 1 commit into
nodejs:masterfrom
batrla:master
Closed

test-crypto-fips.js fails with shared OpenSSL 3#42947
batrla wants to merge 1 commit into
nodejs:masterfrom
batrla:master

Conversation

@batrla

@batrlabatrla commented May 2, 2022

Copy link
Copy Markdown
Contributor

closes#42827

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 2, 2022
@mhdawson

mhdawson commented May 2, 2022

Copy link
Copy Markdown
Member

@danbev can you take a look at this one?

@nodejs-github-bot

nodejs-github-bot commented May 3, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43848/

@tniessen
tniessen requested a review from bnoordhuisMay 3, 2022 13:11
mhdawson
mhdawson approved these changes May 4, 2022
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented May 4, 2022

Copy link
Copy Markdown
Member

Landed in 2454aa0

@mhdawsonmhdawson closed this May 4, 2022
mhdawson pushed a commit that referenced this pull request May 4, 2022
@batrla@mhdawson
test: fix test-crypto-fips.js under shared OpenSSL
2454aa0
Fixes: #42827
PR-URL: #42947
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@batrla@RafaelGSS
test: fix test-crypto-fips.js under shared OpenSSL
d746207
Fixes: #42827
PR-URL: #42947
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request May 10, 2022
Merged
@juanarbol

juanarbol commented May 31, 2022

Copy link
Copy Markdown
Member

OpenSSL 3 is not part of v16.x

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@tniessentniessentniessen approved these changes
+2 more reviewers
@danbevdanbevdanbev approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test/parallel/test-crypto-fips.js fails if node is built with --shared-openssl and --openssl-is-fips

7 participants

@batrla@mhdawson@nodejs-github-bot@juanarbol@bnoordhuis@danbev@tniessen