Skip to content

doc: improve commit message example for releases - #42954

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
juanarbol:juan/release-docs
May 6, 2022
Merged

doc: improve commit message example for releases#42954
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
juanarbol:juan/release-docs

Conversation

@juanarbol

@juanarboljuanarbol commented May 3, 2022

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented May 3, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 3, 2022
richardlau
richardlau reviewed May 3, 2022
View reviewed changes
Comment threaddoc/contributing/releases.md Outdated
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2022
mhdawson
mhdawson approved these changes May 4, 2022
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1834478 into nodejs:masterMay 6, 2022
@nodejs-github-bot

nodejs-github-bot commented May 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1834478

RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@juanarbol@RafaelGSS
doc: improve commit message example for releases
840e61e
PR-URL: #42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol added a commit that referenced this pull request May 31, 2022
@juanarbol
doc: improve commit message example for releases
54e4f05
PR-URL: #42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@juanarbol@danielleadams
doc: improve commit message example for releases
ff65818
PR-URL: #42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@juanarbol@targos
doc: improve commit message example for releases
48a11e3
PR-URL: #42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@juanarbol@targos
doc: improve commit message example for releases
14569c7
PR-URL: #42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@juanarbol@guangwong
doc: improve commit message example for releases
4b65350
PR-URL: nodejs/node#42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
@juanarbol
juanarbol deleted the juan/release-docs branch October 24, 2022 13:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@trivikrtrivikrtrivikr approved these changes
@marsonyamarsonyamarsonya approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+2 more reviewers
@danielleadamsdanielleadamsdanielleadams approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@juanarbol@nodejs-github-bot@lpinca@tniessen@richardlau@danielleadams@BethGriggs@mhdawson@trivikr@marsonya@RaisinTen