Uh oh!
There was an error while loading. Please reload this page.
lib: move WebAssembly Web API into separate file - #42993
Merged
nodejs-github-bot merged 1 commit intoMay 8, 2022
Merged
Conversation
nodejs-github-bot
commented
May 6, 2022
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
devsnek
approved these changes
May 6, 2022
aduh95
approved these changes
May 6, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tniessenforce-pushed
the
wasm-web-api-move-js-into-different-file
branch
from
May 6, 2022 21:36
899de1c to
7184d3dComparetniessen
commented
May 6, 2022
MemberAuthor
Thanks @aduh95. Rebased, the diff is 899de1c7fdf7d1913cc6e438a7842d774bc4bc3c. |
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
May 6, 2022
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
May 7, 2022
Collaborator
juanarbol
approved these changes
May 7, 2022
RaisinTen
approved these changes
May 7, 2022
nodejs-github-bot
commented
May 8, 2022
Collaborator
Landed in e8e6d45 |
RafaelGSS pushed a commit
that referenced
this pull request
May 10, 2022
Refs: #42960 (comment) PR-URL: #42993 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
This was referenced May 12, 2022
This was referenced May 13, 2022
juanarbol
commented
May 31, 2022
Member
Backport refs: #42701 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves just the JavaScript part of the WebAssembly Web API implementation into a separate file to avoid bloating
pre_execution.js.Refs: #42960 (comment)