Uh oh!
There was an error while loading. Please reload this page.
dgram: remove a needless instanceof Buffer check - #4301
Closed
ronkorving wants to merge 1 commit into
Closed
Conversation
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not.
cjihrig
commented
Dec 16, 2015
Contributor
LGTM |
mscdex
commented
Dec 16, 2015
Contributor
LGTM |
1 similar comment
silverwind
commented
Dec 16, 2015
Contributor
LGTM |
silverwind
commented
Dec 16, 2015
Contributor
Superfluos CI: https://ci.nodejs.org/job/node-test-pull-request/1011/ |
silverwind pushed a commit
that referenced
this pull request
Dec 16, 2015
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: #4301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
commented
Dec 16, 2015
Contributor
Thanks! Landed in 4b267df. |
ronkorving
commented
Dec 16, 2015
ContributorAuthor
That was fast :) Thanks. |
silverwind
commented
Dec 16, 2015
Contributor
Well, that was easy to review 😉. Oh, and I noticed the module name should have been |
ronkorving
commented
Dec 16, 2015
ContributorAuthor
Too late to change the commit log I guess, but I renamed the PR. |
silverwind
commented
Dec 16, 2015
Contributor
Yeah, not going to force-push for something negligible like that 😉. |
cjihrig pushed a commit
that referenced
this pull request
Dec 16, 2015
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: #4301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io> Conflicts: lib/dgram.js
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 30, 2015
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: #4301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: #4301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: nodejs#4301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer.