Uh oh!
There was an error while loading. Please reload this page.
src,lib: migrate to console on context's extra binding - #43142
Closed
legendecas wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
May 18, 2022
Collaborator
Review requested:
|
legendecas
marked this pull request as ready for review
May 18, 2022 15:33
nodejs-github-bot
commented
May 21, 2022
Collaborator
joyeecheung
approved these changes
May 23, 2022
JungMinu
approved these changes
May 23, 2022
legendecas added a commit
that referenced
this pull request
May 23, 2022
Since `globalThis.console` is not an ECMAScript defined builtin, V8's globally installed `console` implementation is been moved to the context's extra binding object. We need to migrate to that one before the globally installed console object is removed in V8. PR-URL: #43142 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
legendecas
commented
May 23, 2022
MemberAuthor
Landed in b92bc59 |
legendecas
commented
May 23, 2022
MemberAuthor
Thank you for reviewing! |
bengl pushed a commit
that referenced
this pull request
May 30, 2022
Since `globalThis.console` is not an ECMAScript defined builtin, V8's globally installed `console` implementation is been moved to the context's extra binding object. We need to migrate to that one before the globally installed console object is removed in V8. PR-URL: #43142 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
globalThis.consoleis not an ECMAScript defined builtin, V8's globally installedconsoleimplementation is been moved to the context's extra binding object: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/init/bootstrapper.cc;l=4429?q=bootstrapper.ccWe need to migrate to that one before the globally installed console object is removed in V8.