Skip to content

meta: add mailmap entry for Morgan Roderick - #43144

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:add/mailmap-entry-for-morgan-roderick
May 19, 2022
Merged

meta: add mailmap entry for Morgan Roderick#43144
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:add/mailmap-entry-for-morgan-roderick

Conversation

@lpinca

@lpincalpinca commented May 18, 2022

Copy link
Copy Markdown
Member

As titled.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 18, 2022
Trott
Trott approved these changes May 18, 2022
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need that first line, but also probably OK to include it as a form of future-proofing.

@TrottTrott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 18, 2022
@github-actions

github-actionsBot commented May 18, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@lpinca

lpinca commented May 18, 2022

Copy link
Copy Markdown
MemberAuthor

Probably don't need that first line, but also probably OK to include it as a form of future-proofing.

Yes, there are a few occurrences like this. I've copied the one above it.

@Trott

Trott commented May 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Probably don't need that first line, but also probably OK to include it as a form of future-proofing.

Yes, there are a few occurrences like this. I've copied the one above it.

For anyone who cares about the details: In some situations it's needed if the same email address appears in the git log with multiple names and you want to make sure one or the other name is used. So if lpinca <lpinca@example.com> and L. Pinca <lpinca@example.com> are both in the git log, and the user definitely wants L. Pinca to show up in AUTHORS and elsewhere and not lpinca, that's when that comes in handy.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2022
@nodejs-github-bot
nodejs-github-bot merged commit efcf07f into nodejs:masterMay 19, 2022
@nodejs-github-bot

nodejs-github-bot commented May 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in efcf07f

@lpinca
lpinca deleted the add/mailmap-entry-for-morgan-roderick branch May 19, 2022 12:49
bengl pushed a commit that referenced this pull request May 30, 2022
@lpinca@bengl
meta: add mailmap entry for Morgan Roderick
7d8d9d6
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@benglbengl mentioned this pull request May 31, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@lpinca@juanarbol
meta: add mailmap entry for Morgan Roderick
236d139
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@lpinca@danielleadams
meta: add mailmap entry for Morgan Roderick
4539d6e
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@lpinca@targos
meta: add mailmap entry for Morgan Roderick
b542d57
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@lpinca@targos
meta: add mailmap entry for Morgan Roderick
bd6912d
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@lpinca@guangwong
meta: add mailmap entry for Morgan Roderick
ceaa2b0
PR-URL: nodejs/node#43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lpinca@Trott@nodejs-github-bot@aduh95