Uh oh!
There was an error while loading. Please reload this page.
doc: fix errors in Performance hooks doc - #43152
Merged
Merged
Conversation
Y1D7NG
commented
May 19, 2022
Contributor
Trott
approved these changes
May 19, 2022
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
himself65
approved these changes
May 19, 2022
nodejs-github-bot
commented
May 19, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43152 ✔ Done loading data for nodejs/node/pull/43152 ----------------------------------- PR info ------------------------------------ Title doc: fix errors in Performance hooks doc (#43152) Author OneNail (@OneNail) Branch OneNail:doc-perf-hooks -> nodejs:master Labels doc, fast-track, perf_hooks Commits 1 - doc: fix errors in Performance hooks doc Committers 1 - OneNail PR-URL: https://github.com/nodejs/node/pull/43152 Reviewed-By: Rich Trott Reviewed-By: Zeyu "Alex" Yang ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43152 Reviewed-By: Rich Trott Reviewed-By: Zeyu "Alex" Yang -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 May 2022 16:02:58 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43152#pullrequestreview-979188144 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43152#pullrequestreview-979343100 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2355056650 |
nodejs-github-bot
commented
May 20, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43152 ✔ Done loading data for nodejs/node/pull/43152 ----------------------------------- PR info ------------------------------------ Title doc: fix errors in Performance hooks doc (#43152) Author OneNail (@OneNail) Branch OneNail:doc-perf-hooks -> nodejs:master Labels doc, fast-track, perf_hooks Commits 1 - doc: fix errors in Performance hooks doc Committers 1 - OneNail PR-URL: https://github.com/nodejs/node/pull/43152 Reviewed-By: Rich Trott Reviewed-By: Zeyu "Alex" Yang ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43152 Reviewed-By: Rich Trott Reviewed-By: Zeyu "Alex" Yang -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 May 2022 16:02:58 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43152#pullrequestreview-979188144 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43152#pullrequestreview-979343100 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2355654087 |
PR-URL: nodejs#43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Trott
commented
May 20, 2022
Member
Landed in 38f4810 |
bengl pushed a commit
that referenced
this pull request
May 30, 2022
PR-URL: #43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
danielleadams pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
targos pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.