Skip to content

doc: use serial comma in errors docs - #43242

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-serial-comma-errors
May 30, 2022
Merged

doc: use serial comma in errors docs#43242
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-serial-comma-errors

Conversation

@tniessen

@tniessentniessen commented May 29, 2022

Copy link
Copy Markdown
Member

node/doc/README.md

Line 21 in 5e9274a

*[Use serial commas][].

Refs: #11321
Refs: #17384

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 29, 2022
@github-actions

github-actionsBot commented May 29, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels May 29, 2022
@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2022
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2022
@nodejs-github-bot
nodejs-github-bot merged commit d72dcb0 into nodejs:masterMay 30, 2022
@nodejs-github-bot

nodejs-github-bot commented May 30, 2022

Copy link
Copy Markdown
Collaborator

Landed in d72dcb0

bengl pushed a commit that referenced this pull request May 30, 2022
@tniessen@bengl
doc: use serial comma in errors docs
0afdc3e
Refs: #11321
Refs: #17384
PR-URL: #43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@benglbengl mentioned this pull request May 31, 2022
Merged
F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 1, 2022
@tniessen@F3n67u
doc: use serial comma in errors docs
d93d3e1
Refs: nodejs#11321
Refs: nodejs#17384
PR-URL: nodejs#43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen@danielleadams
doc: use serial comma in errors docs
a1e9e05
Refs: #11321
Refs: #17384
PR-URL: #43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen@targos
doc: use serial comma in errors docs
a62b1a2
Refs: #11321
Refs: #17384
PR-URL: #43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen@targos
doc: use serial comma in errors docs
f453918
Refs: #11321
Refs: #17384
PR-URL: #43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen@guangwong
doc: use serial comma in errors docs
9c032ed
Refs: nodejs/node#11321
Refs: nodejs/node#17384
PR-URL: nodejs/node#43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.errorsIssues and PRs related to JavaScript errors originated in Node.js core.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen@nodejs-github-bot@lpinca@RaisinTen@VoltrexKeyva