Uh oh!
There was an error while loading. Please reload this page.
buffer: refactor create buffer - #4340
Closed
JacksonTian wants to merge 1 commit into
Closed
Conversation
Use createBuffer to reduce new Uint8Array() and setPrototypeOf.
Fishrock123
commented
Dec 18, 2015
Contributor
bnoordhuis
commented
Dec 18, 2015
Member
LGTM, seems like an uncontroversial change to me. CI: https://ci.nodejs.org/job/node-test-pull-request/1027/ |
JacksonTian
commented
Dec 21, 2015
ContributorAuthor
Thanks @bnoordhuis , seems like two unrelated test cases failed. |
targos
commented
Dec 21, 2015
Member
LGTM |
1 similar comment
ChALkeR
commented
Dec 21, 2015
Member
LGTM |
trevnorris
commented
Dec 21, 2015
Contributor
Benchmarks look good. LGTM |
jasnell pushed a commit
that referenced
this pull request
Dec 24, 2015
Use createBuffer to reduce new Uint8Array() and setPrototypeOf. PR-URL: #4340 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
commented
Dec 24, 2015
Member
Landed in 26a8297 |
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Use createBuffer to reduce new Uint8Array() and setPrototypeOf. PR-URL: nodejs#4340 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit
that referenced
this pull request
Jan 13, 2016
Use createBuffer to reduce new Uint8Array() and setPrototypeOf. PR-URL: #4340 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
Use createBuffer to reduce new Uint8Array() and setPrototypeOf. PR-URL: #4340 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Use createBuffer to reduce new Uint8Array() and setPrototypeOf. PR-URL: nodejs#4340 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use createBuffer to reduce new Uint8Array()
and setPrototypeOf.