Skip to content

test: use Object for tests variable in fs trace test - #43585

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
F3n67u:optimize-test
Jul 9, 2022
Merged

test: use Object for tests variable in fs trace test#43585
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
F3n67u:optimize-test

Conversation

@F3n67u

@F3n67uF3n67u commented Jun 27, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 27, 2022
@F3n67u
F3n67u marked this pull request as ready for review June 27, 2022 05:36
@lpincalpinca added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 27, 2022
@github-actions

github-actionsBot commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 approved these changes Jun 27, 2022
View reviewed changes
Comment threadtest/parallel/test-trace-events-fs-sync.js Outdated
@F3n67u@aduh95
Update test/parallel/test-trace-events-fs-sync.js
dfac3a2
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@F3n67u

F3n67u commented Jun 27, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

cross-compiler-rhel8-armv7-gcc-8-glibc-2.28 failed: No space left on device. I filed a issue for this problem: nodejs/build#2977

@LiviaMedeirosLiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 27, 2022
@F3n67uF3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44918/

This was referenced Jun 28, 2022
Open
Open
@F3n67uF3n67u mentioned this pull request Jun 29, 2022
Closed
@aduh95aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44992/

@github-actionsgithub-actionsBot mentioned this pull request Jul 4, 2022
Open
23 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45076/

@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45116/

@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2022
Open
16 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45161/

@github-actionsgithub-actionsBot mentioned this pull request Jul 9, 2022
Open
21 tasks
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 9, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 138704f into nodejs:mainJul 9, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in 138704f

@F3n67u
F3n67u deleted the optimize-test branch July 9, 2022 12:14
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u@targos
test: use Object for tests variable in fs trace test
c4d88b3
PR-URL: #43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targostargos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u@targos
test: use Object for tests variable in fs trace test
def932e
PR-URL: #43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u@targos
test: use Object for tests variable in fs trace test
11df17c
PR-URL: #43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u@guangwong
test: use Object for tests variable in fs trace test
3aafaae
PR-URL: nodejs/node#43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@aduh95aduh95aduh95 approved these changes
@juanarboljuanarboljuanarbol approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@F3n67u@nodejs-github-bot@jasnell@lpinca@targos@aduh95@juanarbol@LiviaMedeiros