Skip to content

benchmark: fix output regression - #43635

Closed
mscdex wants to merge 1 commit into
nodejs:mainfrom
mscdex:benchmark-fix-output-regression
Closed

benchmark: fix output regression#43635
mscdex wants to merge 1 commit into
nodejs:mainfrom
mscdex:benchmark-fix-output-regression

Conversation

@mscdex

@mscdexmscdex commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Fixes: #43628

@mscdex
mscdex requested a review from ShogunPandaJune 30, 2022 21:47
@nodejs-github-botnodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Jun 30, 2022
ShogunPanda
ShogunPanda approved these changes Jun 30, 2022
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for tackling the mess I introduced!

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45018/

@github-actionsgithub-actionsBot mentioned this pull request Jul 4, 2022
Open
23 tasks
@mscdexmscdex mentioned this pull request Jul 7, 2022
Closed
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45124/

@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2022
Open
16 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45143/

@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45145/

@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45162/

@ShogunPanda

ShogunPanda commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Landed in adef64c

ShogunPanda pushed a commit that referenced this pull request Jul 8, 2022
@mscdex@ShogunPanda
benchmark: fix output regression
adef64c
Fixes: #43628
PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@mscdex
mscdex deleted the benchmark-fix-output-regression branch July 8, 2022 17:04
This was referenced Jul 9, 2022
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@mscdex@targos
benchmark: fix output regression
7ee0be7
Fixes: #43628
PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@mscdex@targos
benchmark: fix output regression
6269549
Fixes: #43628
PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@mscdex@targos
benchmark: fix output regression
3b10a94
Fixes: #43628
PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@mscdex@guangwong
benchmark: fix output regression
e1da0ac
Fixes: nodejs/node#43628
PR-URL: nodejs/node#43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@legendecaslegendecaslegendecas approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

benchmark: run.js output regression after d636fee319bc

9 participants

@mscdex@nodejs-github-bot@ShogunPanda@Trott@lpinca@tniessen@legendecas@BridgeAR@aduh95