Skip to content

child_process: fix setSimultaneousAccepts - #43951

Closed
theanarkh wants to merge 1 commit into
nodejs:mainfrom
theanarkh:fix_setSimultaneousAccepts
Closed

child_process: fix setSimultaneousAccepts#43951
theanarkh wants to merge 1 commit into
nodejs:mainfrom
theanarkh:fix_setSimultaneousAccepts

Conversation

@theanarkh

@theanarkhtheanarkh commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

The error from CI is as follows. When pass the pipe handle by IPC on win32, the bug will be triggered because setSimultaneousAccepts is only defined on tcp handle. In addition, setSimultaneousAccepts should only be valid on tcp server.

error Message
fail (1)
Stacktrace
node:internal/child_process:821
handle.setSimultaneousAccepts(true);
^
TypeError: handle.setSimultaneousAccepts is not a function
at target._send (node:internal/child_process:821:16)
at target.send (node:internal/child_process:738:19)
at sendHelper (node:internal/cluster/utils:28:15)
at RoundRobinHandle.handoff (node:internal/cluster/round_robin_handle:128:3)
at RoundRobinHandle.distribute (node:internal/cluster/round_robin_handle:108:10)
at handle.onconnection (node:internal/cluster/round_robin_handle:45:54)
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 22, 2022

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a test?

Comment threadlib/internal/child_process.js Outdated
Comment threadlib/internal/child_process.js Outdated
@theanarkh
theanarkhforce-pushed the fix_setSimultaneousAccepts branch 6 times, most recently from dd49d1e to 21cae86CompareJuly 23, 2022 08:17
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@theanarkh
theanarkhforce-pushed the fix_setSimultaneousAccepts branch from 21cae86 to 2cdea07CompareJuly 23, 2022 14:43
@F3n67uF3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_processIssues and PRs related to the child_process subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@theanarkh@nodejs-github-bot@cjihrig@F3n67u